(Make Core feedback) Accessibility Review

[krogsgard]

I'm leaving this as a single issue for now. We may need to break it out into multiple issues, but many of these can be knocked out together. The user search bug and usage of wp.a11y.speak() may need to be broken out.

From Joe Dolson:

On /wp-admin/users.php?page=rest-oauth1-apps Labeling:

1. Is "Select Consumer" a good label for the application checkbox? "Select Application '{app name}'" would provide better context
2. Use of language is consistent: Admin menu links to "applications"; page title is 'Edit Applications', but you add and select 'consumers'.
3. Row actions: add application name to 'Edit' and 'Delete' as aria label or screen reader text

Other notes:

1. Bug: Search query on OAuth apps page executes a user search

On /wp-admin/users.php?page=rest-oauth1-apps&action=add

Form labeling & feedback:

1. Add aria-describedby referencing descriptions for Consumer Name & Callback
2. Indicate that all fields are required
3. Return all errors rather than just the first error produced
4. Append an ID to form actions so that post-submission focus lands in a useful location

Structure:

1. Promote H2 heading to H1
2. Promote H3 heading to H2
3. Replace form <table> structures or mark explicitly with role="presentation". (But keep table structure on Credentials; that's helpful.)

Other notes:

1. Consider using AJAX for form submissions + wp.a11y.speak() for feedback? Would provide more rapid feedback for users of screen readers by not requiring page refresh.

[rmccue]

Started work on this in #174. I have a few questions:

Append an ID to form actions so that post-submission focus lands in a useful location

Not really sure what this one means? Is this after submitting the creation form?

Replace form <table> structures or mark explicitly with role="presentation". (But keep table structure on Credentials; that's helpful.)

This doesn't seem to match what core has; happy to add, but should be consistent too.