SMACT icon indicating copy to clipboard operation
SMACT copied to clipboard

[WIP] Documentation overhaul

Open AntObi opened this issue 1 year ago • 2 comments

Overhauling the documentation

Description

N/A

Closes #67 Closes #297

Type of change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update

How Has This Been Tested?

TBC

Test Configuration:

  • Python version: 3.10
  • Operating System: macOS

Reviewers

N/A

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

Summary by CodeRabbit

  • New Features

    • Enhanced documentation with improved formatting and clarity in the README.md and CONTRIBUTING.md files, facilitating better user navigation and understanding.
    • Introduced support for Jupyter notebooks in documentation, enhancing accessibility for users.
    • Added a new tutorials guide to help users navigate practical applications of the smact library.
    • Expanded the introduction section to outline key features and installation instructions for the smact module.
  • Documentation

    • Standardised section headers and improved overall structure in documentation files, making it easier for users to find relevant information.
    • Updated project metadata in configuration files to reflect branding consistency and enhance discoverability.
    • Changed the HTML theme and added new options for better visual presentation and navigation in documentation.
  • Chores

    • Minor updates to configuration files for improved clarity and consistency.
    • Updated dependencies in project configuration to ensure compatibility with newer features.

AntObi avatar Aug 30 '24 16:08 AntObi

Walkthrough

The changes encompass various modifications across multiple files, including updates to documentation, formatting adjustments, enhancements to type hinting, and improvements in error handling. The updates also involve reorganising sections in templates, refining workflows, and expanding documentation to provide clearer guidance on functionalities. Overall, these changes aim to enhance code clarity, maintainability, and usability without altering the core logic of the existing functionalities.

Changes

Files Change Summary
CONTRIBUTING.md, README.md, docs/*.rst Formatting adjustments, content reorganisation, and minor textual edits for clarity.
docs/conf.py Added myst_nb extension and updated project metadata.
docs/examples/*.ipynb, docs/tutorials/*.rst Updated content and structure for improved clarity and accessibility.
pyproject.toml, setup.py Significant updates for packaging, dependency management, and author information.
smact/*.py Enhanced type hinting, updated docstrings, and improved error handling across several modules.
smact/tests/*.py Formatting improvements in test cases and added future import for type hinting.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant System
    participant Documentation
    participant Codebase

    User->>System: Request for functionalities
    System->>Documentation: Retrieve updated documentation
    Documentation-->>User: Provide clear guidance
    User->>Codebase: Execute functions
    Codebase-->>User: Return results

🐰 "In fields of code, I hop with glee,
Changes abound, as bright as can be!
From templates to docs, all polished and neat,
A world of knowledge, oh what a treat!
With every update, I dance and I play,
Celebrating progress, hip-hip-hooray!"
🌼

Assessment against linked issues

Objective Addressed Explanation
Running examples from a browser (#67)
Move to ruff for linting and formatting (#297)

[!TIP] We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 30 '24 16:08 coderabbitai[bot]

Codecov Report

Attention: Patch coverage is 65.20619% with 135 lines in your changes missing coverage. Please review.

Project coverage is 72.42%. Comparing base (a7946c9) to head (5167778). Report is 364 commits behind head on develop.

Files with missing lines Patch % Lines
smact/structure_prediction/prediction.py 21.62% 29 Missing :warning:
smact/data_loader.py 54.54% 15 Missing :warning:
smact/__init__.py 77.41% 7 Missing :warning:
smact/distorter.py 12.50% 7 Missing :warning:
smact/properties.py 46.15% 7 Missing :warning:
smact/structure_prediction/mutation.py 68.18% 7 Missing :warning:
smact/structure_prediction/structure.py 65.00% 7 Missing :warning:
smact/dopant_prediction/doper.py 64.70% 6 Missing :warning:
smact/utils/band_gap_simple.py 0.00% 6 Missing :warning:
...ls/crystal_space/download_compounds_with_mp_api.py 0.00% 6 Missing :warning:
... and 13 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #309      +/-   ##
===========================================
- Coverage    76.46%   72.42%   -4.05%     
===========================================
  Files           26       30       +4     
  Lines         2265     2415     +150     
===========================================
+ Hits          1732     1749      +17     
- Misses         533      666     +133     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 31 '24 08:08 codecov[bot]