import-maps icon indicating copy to clipboard operation
import-maps copied to clipboard

External import maps support

Open guybedford opened this issue 4 years ago • 38 comments

Currently external import maps are specified here, but in Chrome these still give the error:

External import maps are not yet supported.

I think it could be useful to clearly indicate in the spec that this is an optional feature of the implementation here, or possibly even split it out, given the current movements - especially when other browsers are being asked to consider implementation work.

guybedford avatar Oct 30 '20 19:10 guybedford

We're hoping to implement ASAP, although there may be a 6-week period where they aren't implemented.

domenic avatar Oct 30 '20 19:10 domenic

Ok, if that's the plan then this can be closed certainly.

guybedford avatar Oct 30 '20 21:10 guybedford

What's the current planning on this?

LarsDenBakker avatar Jan 22 '21 22:01 LarsDenBakker

@hiroshige-g, how's the external import maps implementation going?

domenic avatar Jan 22 '21 22:01 domenic

@domenic thinking about the performance tradeoff here - does encouraging speculative fetching avoid the problem?

guybedford avatar Mar 03 '21 08:03 guybedford

I put together some thoughts and a benchmark in this document about this topic: https://docs.google.com/document/d/1IxkNGRIUbvQ0P8Uig9jkFte5gACCn-Y9zO1P5acnE9s/edit#

joeldenning avatar Mar 03 '21 16:03 joeldenning

One of my main points in that document:

External import maps can be controlled and cached separately from the HTML files that reference them, which allows for updating javascript resources without busting the cache for the main HTML resource.

joeldenning avatar Mar 03 '21 16:03 joeldenning

I believe "external" import maps of course needs to be supported. Its the developer's decision, which one to choose.

Just stumbled upon this issue. I thought Chrome supports import maps fully. Just when, oh when, web will finally switch to bunder-free development?

Spend whole day yesterday trying to make Snowpack to work with my app, trying Vite today. Keep filing github issues. Feel my pain. All I need is a simple bare specifier support in few places.

canonic-epicure avatar May 21 '21 09:05 canonic-epicure

hey everyone just bumping on this - do we have an updated eta on external import maps anywhere?

davidmarkclements avatar Jul 07 '21 17:07 davidmarkclements

Hi guys, are there any news on this front? Import maps served via API would give us more options/flexibility.

nenadvicentic avatar Oct 08 '21 13:10 nenadvicentic

We have continued to fail to gather enough implementation bandwidth in Chromium to ship external import maps, despite them being specified. At this point we're considering removing them from the spec, at least temporarily, and moving them to the "future extensions" section of the README for whenever we have time. Otherwise the spec is just misleading.

It would be helpful if people who want this feature were able to add a thumbs-up emoji to the original post here. That would help us track developer sentiment on this potential future extension, versus others.

domenic avatar Oct 14 '21 20:10 domenic

For clarity’s sake:

  1. What is the main reason that implementers don’t want to support this?
  2. How many “thumbs up” would be required for it to be considered for staying in the spec? And for implementation?
  3. Is there any actual harm in keeping it in the spec even if it’s not implemented yet?

frehner avatar Oct 14 '21 20:10 frehner

Good questions.

What is the main reason that implementers don’t want to support this?

I don't think anyone doesn't want to support this. Speaking for Chrome at least, the issue is that it's a good amount of work, and we have limited engineers. (E.g. the time I'm spending on import maps today is taking away time from app history, where I know you're also involved.) Nobody on the Chrome team is currently assigned to work on import maps.

How many “thumbs up” would be required for it to be considered for staying in the spec? And for implementation?

I don't think we can give a concrete number. Rather, this is a question of us going to our bosses and saying "please assign an engineer to work on import maps". If we do that with 5 thumbs-up, it's pretty weak-sauce. If we do that with five thousand thumbs up, they're going to be excited about making that many developers happy, and probably give us the resources. I assume the real number will be somewhere in between.

There's also the issue that if we do get that engineer to work on import maps, how do we prioritize external import maps vs. the other future extensions listed in the README, or other open issues (which I'm working on triaging now)? For that, the relative weight of the thumbs-up on different issues can help, although of course it is only a factor and not some sort of binding ranking.

Is there any actual harm in keeping it in the spec even if it’s not implemented yet?

Yes. Specifying fiction is harmful to the ecosystem in a number of ways; it misleads developers about what's implemented, and it misleads implementers about what behaviors are solid and debugged and battle-tested. We try to make sure specifications are backed by implementations as part of the working mode for the WHATWG; although this is not a WHATWG spec yet, it hopes to one day graduate to become one.

domenic avatar Oct 14 '21 21:10 domenic

Thank you for the detailed response. 👍🏼

frehner avatar Oct 14 '21 21:10 frehner

FWIW Deno has an --import-map flag, that currently accepts a file path or a URL that allows to load both local and remote import map. I know this is not directly linked to the issue at hand but we found ability to load remote import maps useful. Thumbs up from me.

bartlomieju avatar Oct 16 '21 02:10 bartlomieju

Hopefully there's been enough 👍 to indicate how valuable this feature is for developers, and maybe enough for a manager at Google to assign an engineer to implement it? (Wishful thinking 🙂 )

One of the most common reasons I saw as to why this is important was:

Being able to separate the import map from the HTML would greatly improve developer tooling; it's harder to update an inlined import map and then bust the cache for the HTML page than it would be to have a separate (purely JSON) import map that tools can easily parse and update. That also allows developers to have separate caching strategies for the HTML and the import map, where generally the HTML can essentially have a max-life TTL while the import map can have a shorter one (minutes?) so it can still be updated fairly regularly.

For context, I think the vast majority (+95% ?) of setups we see in single-spa community use a remote import map (through SystemJS) for these reasons.

[edit] Another key point is that remote import maps are sharable; in other words, if you have two websites, both of them can refer to the same import map. You can update a single import map and have those mappings updated at the same time for both websites. [/edit]

In any case, thank you for your work. 🙂

frehner avatar Oct 19 '21 15:10 frehner

Another reason (which was not mentioned yet AFAIK) would be that, because the importmap is a script tag, you can't use an inline importmap if serving the page with a strict CSP, e.g. without the unsafe-inline keyword:

Refused to execute inline script because it violates the following Content Security Policy
directive: "script-src 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-...'),
or a nonce ('nonce-...') is required to enable inline execution.

To be consistent, I would rather have no inline script at all, even for the importmap.

quotquot avatar Oct 22 '21 14:10 quotquot

I'm having an issue trying to understand why it would be that much work to make it work externally, like every other script tag works internal or external. The only difference here is verifying the content-type of application/importmap+json being returned. It's not reinventing the wheel.... unless chrome is a pile of spaghetti and it is reinventing the wheel.

Brain2000 avatar Dec 29 '21 00:12 Brain2000

This isn't "formally" an external importmap, but it works:

test.htm:

<html>
<head>
<script src="./importmap.js"></script>

<script type="module">
import 'my-library'; // will fetch the randomly-chosen URL
</script>

</head>
<body>
</body>
</html>

importmap.js:

const im = document.createElement('script');
im.type = 'importmap';
im.textContent = JSON.stringify({
  imports: {
    'my-library': Math.random() > 0.5 ? '/path1.js' : '/path2.js'
  }
});
document.currentScript.after(im);

Brain2000 avatar Dec 29 '21 00:12 Brain2000

I've also found that this does not work with importmaps, though I should probably open a separate issue for this:

<link rel="modulepreload" href="my-library">

This always loads "my-library" verbatim instead of what the importmap depicts. This breaks some bundlers, like vite, which injects a number of modulepreloads.

Brain2000 avatar Dec 29 '21 20:12 Brain2000


{
  "imports": {
    "a": "/a-1.mjs",
    "b": "/b-1.mjs",
    "c": "/c-1.mjs"
  },
  "scopes": {
    "/scope2/": {
      "a": "/a-2.mjs"
    },
    "/foo/": "/foo.map.json"
  }
}

I think external maps should be allowed for different scope.

masx200 avatar Aug 14 '22 04:08 masx200

@masx200 specifically defining scope boundaries for externalization is a nice thought! That said, import map resolutions cannot be individually asynchronous therefore allowing specific resolutions to trigger and wait on async import map fetching work is not possible.

guybedford avatar Aug 14 '22 12:08 guybedford

{
"externals":{
"http://example.com/foo/":"http://example.com/foo/import_map.json"

},
  "imports": {
    "a": "http://example.com/a/mod.mjs",
    "scope2/": "http://example.com/scope2/",
    "foo/":"http://example.com/foo/"
  },
  "scopes": {
    "http://example.com/scope2/": {
      "b": "http://example.com/b/mod.mjs"
    }
    
  }
}

masx200 avatar Aug 15 '22 23:08 masx200

Has any decision been made on whether external import maps will be supported?

I am using Importmaps as in the below example:

<!doctype html>
<html>
  <head>
    <title>Demo</title>
    <link rel="icon" href="favicon.ico" type="image/x-icon">
    <link rel="stylesheet" href="html.style.css">
    <script type="importmap">
      {
          "imports": {
            "@browser-modules/dictionary": "../node_modules/@browser-modules/dictionary/lib/dictionary.js",
            "@browser-modules/events": "../node_modules/@browser-modules/events/lib/events.js",
            "@browser-modules/component.library": "../node_modules/@browser-modules/component.library/lib/library.js",	
            "@browser-modules/machine": "../node_modules/@browser-modules/machine/lib/machine.js",
            "@browser-modules/web.component": "../node_modules/@browser-modules/web.component/lib/component.js",
            "@browser-modules/buttons": "../node_modules/@browser-modules/buttons/lib/buttons.js"
          }
      }
    </script>
  </head>
  <body>
    <script src="index.js" type="module"></script>
    <task-bar></task-bar>
  </body>
</html>

However, I realize that the list of imports will soon be extensive, and instead, I prefer to use external import maps.

Can anyone tell me if this GitHub issue will be addressed?

FlippieCoetser avatar May 16 '23 11:05 FlippieCoetser

We're hoping to implement ASAP, although there may be a 6-week period where they aren't implemented.

I am LOVING the optimism of this 3-year old comment 😂

Just adding my voice those eagerly awaiting this feature 👀

pookage avatar Oct 31 '23 14:10 pookage

As an idea, what about a simple polyfill that takes external import map file and inline its content into HTML code? This would allow developers to use external import maps now. This could be implemented both in runtime and at build time (e.g. as a Rollup plugin).

FluorescentHallucinogen avatar Nov 19 '23 12:11 FluorescentHallucinogen

@FluorescentHallucinogen I believe the challenge with the approach you outline is that any javascript that fetches an external file runs async, which runs only after the importmap has been loaded. Ideally, we need support by default for external importmap. Or am I missing something here?

FlippieCoetser avatar Nov 19 '23 13:11 FlippieCoetser

@domenic, I noticed that in the second comment in the list, you provided an estimated timeline. Since it is a rather old comment, could you share your thoughts on when external import maps will be supported? No pressure; I want to calibrate my expectations. Such functionality will really be helpful.

FlippieCoetser avatar Nov 19 '23 13:11 FlippieCoetser

I have no estimate at this time.

domenic avatar Nov 20 '23 00:11 domenic

@FlippieCoetser

I believe the challenge with the approach you outline is that any javascript that fetches an external file runs async, which runs only after the importmap has been loaded.

Not sure about run-time polyfill, but it's definitely possible at build-time (including serving project while developing). I've developed a dirty proof-of-concept, and it works! See https://github.com/modernweb-dev/web/issues/2562#issuecomment-1817907520 for more info. 😉

All tools I know (https://github.com/jsenv/importmap-node-module, https://www.npmjs.com/package/importly) generate import maps as external files.

BTW, maybe nginx can be configured somehow to inline/inject import map from an external file into the index.html code on the fly. 🤔

FluorescentHallucinogen avatar Nov 20 '23 17:11 FluorescentHallucinogen