fenced-frame icon indicating copy to clipboard operation
fenced-frame copied to clipboard

Published 20 hours ago • verified publisher icon WICG

Spec disableUntrustedNetwork API surface

Open gtanzer opened this issue 10 months ago • 5 comments

Preview | Diff

gtanzer avatar Apr 03 '24 19:04 gtanzer

Addressed comments % a question about "default" vs "initial" values.

gtanzer avatar Apr 11 '24 18:04 gtanzer

Can you just "resolve" all comment threads that have been resolved at this point?

domfarolino avatar May 04 '24 20:05 domfarolino

And resolve the merge conflict that this PR now has with master?

domfarolino avatar May 04 '24 20:05 domfarolino

@domfarolino Fixed merge conflicts.

The open threads aren't resolved per se. They depend on your response here: (whether I should commit the suggestions or do nothing) https://github.com/WICG/fenced-frame/pull/146/#discussion_r1559812615

gtanzer avatar May 04 '24 20:05 gtanzer

I don't care which word we use "default" vs "initial". I just want it to be consistent, and this PR makes it inconsistent with https://github.com/WICG/fenced-frame/pull/146/files#diff-6f5a1d8263b0b0c42e2716ba5750e3652e359532647ac934c1c70086ae3ceddaR1213. So I'd either make this PR consistent with https://github.com/WICG/fenced-frame/pull/146/files#diff-6f5a1d8263b0b0c42e2716ba5750e3652e359532647ac934c1c70086ae3ceddaR1213 or make that line consistent with this PR. Whichever word you prefer.

domfarolino avatar May 04 '24 20:05 domfarolino