directory-upload icon indicating copy to clipboard operation
directory-upload copied to clipboard

Consider changing the boolean param of getFiles to a dictionary

Open smaug---- opened this issue 8 years ago • 2 comments

d.getFiles({recursive: true}) would be, IMO a bit more clear than d.getFiles(true), and by using dictionary we could extend the functionality easily later, if wanted. For example in the future we could add { filter: ".html,.htm" } there or some such.

@bakulf, @jwatt, @aliams

smaug---- avatar Mar 24 '16 20:03 smaug----

http://ariya.ofilabs.com/2011/08/hall-of-api-shame-boolean-trap.html

smaug---- avatar Mar 24 '16 20:03 smaug----

Point well taken; ok, this makes sense.

arunranga avatar Mar 28 '16 11:03 arunranga