background-fetch icon indicating copy to clipboard operation
background-fetch copied to clipboard

Make bikeshed complain less

Open miketaylr opened this issue 3 years ago • 5 comments

It seems there's a lot of busted links. I'll fix... some of them.

miketaylr avatar Oct 18 '21 18:10 miketaylr

https://github.com/whatwg/fetch/commit/efde35d09e268046036759b98e30a7693e08517e is responsible for LINE ~297: No 'dfn' refs found for 'transmitted bytes'.

https://github.com/whatwg/fetch/commit/7e5c9225a02b6b4d1f1e21f9f273710089206ce1 is responsible for LINE ~296: No 'dfn' refs found for 'process request body'.

miketaylr avatar Oct 18 '21 18:10 miketaylr

https://github.com/whatwg/fetch/commit/12dd6fa8ca76bd3bdff0c65a0c5a84b3ca870c3d#diff-b4827ee42aceaf9dc3e7216f72262d81c32217e9996fb70a657f259e3ac92604L168 created LINK ERROR: No 'dfn' refs found for 'process response' that are marked for export.

miketaylr avatar Oct 18 '21 19:10 miketaylr

I'm not really sure what caused LINE ~701: No 'dfn' refs found for 'wait' that are marked for export.. I ran out of energy. :(

miketaylr avatar Oct 18 '21 19:10 miketaylr

Whenever https://github.com/whatwg/xhr/pull/333 lands/settles, 'process request body' can be fixed (probably?)

miketaylr avatar Oct 18 '21 19:10 miketaylr

Note that for "process request body" while you can fix the xref issue, a more substantial rewrite is needed to align with the new fetch calling conventions.

I recently wrote https://fetch.spec.whatwg.org/#fetch-elsewhere to elaborate a bit on that, though it could be more useful still as that doesn't have examples.

annevk avatar Oct 19 '21 07:10 annevk