background-fetch icon indicating copy to clipboard operation
background-fetch copied to clipboard

Icon fetch does not use CORS

Open annevk opened this issue 6 years ago • 4 comments

At some point @domenic asserted that all new fetches would use CORS. Is that no longer Google's policy?

annevk avatar Oct 02 '18 12:10 annevk

It depends if we see icon fetching as a new thing or not. The intent is to merge icon handling into a single standard - https://github.com/w3c/manifest/pull/710#issuecomment-416106393, and existing icon fetching is no-cors.

jakearchibald avatar Oct 02 '18 12:10 jakearchibald

I mean, any fetches performed by background sync are a new thing, so this should use cors...

domenic avatar Oct 02 '18 17:10 domenic

Those fetches do require CORS, FWIW. It's just the icon fetch that doesn't. Nobody has really defined icon fetching in detail, but "no-cors" seems somewhat reasonable. On the other hand, the more we start doing with those icons, the more problematic "no-cors" becomes.

annevk avatar Oct 02 '18 19:10 annevk

any fetches performed by background sync are a new thing, so this should use cors...

Implementation wise we're reusing the icon fetching stuff from manifest, and the plan is to merge those into one spec.

That said, the new spec could just take a 'mode' option.

jakearchibald avatar Oct 03 '18 08:10 jakearchibald