warframe-items icon indicating copy to clipboard operation
warframe-items copied to clipboard

:clock1030: Convert warframe-items to ES

Open TobiTenno opened this issue 4 years ago • 8 comments

TobiTenno avatar Oct 25 '21 22:10 TobiTenno

Converting it to ES would break compatibility with commonJs but not the other way around, so why should it be converted?

AyAyEm avatar Nov 05 '21 09:11 AyAyEm

generally? because that's the way js is going in general, so at some point i'll be unable to update dependencies otherwise

TobiTenno avatar Nov 06 '21 04:11 TobiTenno

generally? because that's the way js is going in general, so at some point i'll be unable to update dependencies otherwise

It depends on the project, but warframe-items only has dev-dependencies so i see no point to update it, unless node is discarding cjs compatibility.

If you're looking for both, maybe a TS rewrite? At least the npm package side of the project isn't large.

AyAyEm avatar Nov 09 '21 13:11 AyAyEm

I'm not converting it to TS.

The purpose is futureproofing for the end of cjs as ES is the standard as of node 12 is moving to EOL.

I still have to be able to upgrade dev-dependencies, and as those move to non-CJS, I have to adapt

TobiTenno avatar Nov 10 '21 01:11 TobiTenno

Could you explain why it would be a good idea to move a library that does not require ES to ES? Sorry, but i'm kind confused here. Also i don't understand why it matters if it's standard to ES, as far as i know CJS will continue to be supported. Basically what i'm getting is that you want to break compatibility with the projects that use warframe-items, and i can't see why.

AyAyEm avatar Nov 11 '21 16:11 AyAyEm

CJS will continue to be supported, but many large projects are moving their codebases to ES packages and exports, meaning if I don't upgrade, the dev dependencies we use would no longer work.

I have a standing issue out to both notify and help people prepare, because it's simpler to get people started moving the same direction than to drop a bomb when a bunch of my own development packages that I use or maintain end up unusable.

TobiTenno avatar Nov 11 '21 21:11 TobiTenno

I think we're talking about two things here which got both of us confused, i'm talking about the npm package for warframe-items which doesn't have any dependency, and i think you're talking about the build side of the project which does have dependencies. So with that out of the way i do agree that it's best to move the build side to ES but not the package in npm.

AyAyEm avatar Nov 11 '21 22:11 AyAyEm

yeah, for now i don't plan on changing the availability of the package to everyone. sorry for getting so much confusion in there!

TobiTenno avatar Nov 11 '21 22:11 TobiTenno

:tada: This issue has been resolved in version 1.1258.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

wfcd-bot-boi avatar Nov 29 '22 23:11 wfcd-bot-boi