WEC-Sim_Applications icon indicating copy to clipboard operation
WEC-Sim_Applications copied to clipboard

Update MoorDyn and Paraview examples to be compatible with new MoorDyn v2 format

Open jtgrasb opened this issue 1 year ago • 5 comments

This PR goes along with WEC-Sim PR#1212 to update the RM3 MoorDyn examples to be compatible with the new v2 capabilities and format. This includes updating both the Mooring/MoorDyn example and the Paraview_Visualization\RM3_MoorDyn_Viz example.

jtgrasb avatar Jan 30 '24 17:01 jtgrasb

@jtgrasb, I added the Mooring folder into the Windows tests today, which is why this PR is failing now. I tried to merge in the changes on the dev branch, but that didn't help (maybe made it worse?).

The errors it's throwing are:

Failed to find 'WECSim_Lib_Moorings/MoorDynCaller' in library 'WECSim_Lib_Moorings' referenced by 'RM3MoorDyn/MoorDynCaller'
Failed to find 'WECSim_Lib_Moorings/MoorDynConnection' in library 'WECSim_Lib_Moorings' referenced by 'RM3MoorDyn/MoorDynConnection'

The test is working on the dev branch, so I'm not sure what has happened here, Sorry.

H0R5E avatar Feb 14 '24 11:02 H0R5E

@H0R5E Thanks for adding the MoorDyn folder to the tests. This PR goes along with some updates to the Mooring Library in WEC-Sim which aren't merged yet, so it is expected that the mooring tests will fail until that PR is merged into dev

jtgrasb avatar Feb 21 '24 19:02 jtgrasb

@jtgrasb

it is expected that the mooring tests will fail until that PR is merged into dev

Thanks for the heads up!

H0R5E avatar Feb 22 '24 10:02 H0R5E

@dav-og I've attached a zip file with the results from the old version. You can use it to compare to the new version.

As for the testing, the tests are already set up to load in the MoorDyn repository to run the applications case. One thing that will need to be addressed at some point is the operating system we test it on (MD has different files for windows, linux, and mac), but I think this can be revisited with all the rest of the tests.

WS+MDv1_res.zip

jtgrasb avatar Mar 20 '24 15:03 jtgrasb

Awesome! Thanks Jeff! 👍

dav-og avatar Mar 20 '24 15:03 dav-og