scholia icon indicating copy to clipboard operation
scholia copied to clipboard

[WIP] Implements SPARQL-level config for ASK queries

Open egonw opened this issue 4 months ago • 4 comments

Description

So far, ASK queries were always run against the globally defined SPARQL endpoint. This patch added the option to configure this for each SPARQL query separately.

Caveats

Non-trivial to test.

  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update
    • [ ] I have made corresponding changes to the documentation
  • [ ] This change requires new dependencies (please list)

Testing

For the example configured ASK query:

  • Go to https://scholia.toolforge.org/work/Q30149558#cito-incoming
  • Ensure that the "Reasons why this article is cited" shows up (compare with the live website):
image

Checklist

  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] My changes generate no new warnings
  • [ ] I have not used code from external sources without attribution
  • [ ] I have considered accessibility in my implementation
  • [ ] There are no remaining debug statements (print, console.log, ...)

egonw avatar Aug 23 '25 20:08 egonw

Locally, I do not get the error. But it's reproducible. Just not sure right now how to fix this. Will try that later.

egonw avatar Aug 23 '25 20:08 egonw

There is an error for test_work_cito. Is this just a temporary backend error? Or is it a Scholia error?

fnielsen avatar Aug 25 '25 13:08 fnielsen

There is an error for test_work_cito. Is this just a temporary backend error? Or is it a Scholia error?

@fnielsen, I have yet to explore this. That's why I tagged this PR as draft. I am sorry that was not clear enough. I will debug asap, but in a meeting today.

egonw avatar Aug 25 '25 15:08 egonw

Ok. I did not see the "draft".

fnielsen avatar Aug 25 '25 17:08 fnielsen