scholia icon indicating copy to clipboard operation
scholia copied to clipboard

added birth and death dates to author timeline

Open stuartyeates opened this issue 1 year ago • 1 comments

Fixes # (issue number, if applicable)

Description

added birth and death dates to the author timeline

Caveats

  • I've only tested this on https://query.wikidata.org/ , I don't have a full local stack to test on.
  • This is my first contribution to this project and my first SPARQL contribution to any project.
  • No changes to python code. Two new stanzas in SPQARL query.

Testing

I ran the SPQARL query on https://query.wikidata.org/. the query is too long to use the URL shortener.

Checklist

  • [ X ] My changes generate no new warnings
  • [ X ] I have not used code from external sources without attribution
  • [ X ] I have considered accessibility in my implementation
  • [ X ] There are no remaining debug statements (print, console.log, ...)

stuartyeates avatar Jul 24 '24 09:07 stuartyeates

I'm not bothered with or without the skull. I tried the tombstone emoji, but it didn't work on any of the platforms I tested on so I figured it was too new to be useful.

stuartyeates avatar Aug 03 '24 11:08 stuartyeates

I almost recall some concert about showing birthdate and date of death. I suppose we can keep it for now and remove it if users find it inappropriate.

fnielsen avatar Sep 05 '24 17:09 fnielsen

remove it if users find it inappropriate.

With the risk that those who find it inappropriate will just stay away from Scholia.

But I don't have strong arguments to remove it at this moment.

egonw avatar Sep 06 '24 07:09 egonw

ChatGPT suggests 🏺, ✝️, ⚰️, 🥀. The cross seems tied to a Christian culture, when reminded it suggest ⏳

fnielsen avatar Sep 09 '24 17:09 fnielsen

https://github.com/WDscholia/scholia/issues/2532

fnielsen avatar Sep 09 '24 17:09 fnielsen