applyConfig.py called for each config props file for each configure.sh (.py) file

[scottkurz]

The changes in https://github.com/WASdev/ci.docker.websphere-traditional/pull/157 seem to have broken the Batch sample in this repo.

As you can see in the Dockerfile, this mixes a series of fine-grained .py scripts together with fine-grained properties files.

Pre-157, the way I handled this was to specifically avoid using the filename was-config.props, which was the only path that the call to applyConfig.sh would look to apply when called with zero arguments (at the end of configure.sh).

Now that applyConfig.sh looks for find /work/config -type f -name "*.props" this will look to apply each properties file each time configure.sh is called.

So.. if it's OK to change older builds like this, I can work around again I guess by naming the files *.properties... but maybe at the least there should be a testcase more like this sample somewhere?

---

Also doesn't this line look like it should say /work/applyConfig.sh not work/applyConfig.sh ?

[arthurdm]

thanks Scott. @arturdzm can you please comment? (since this is related to #157)

[scottkurz]

One thing I was wondering but didn't actually say: for a sample this complicated, would it be better to just depend on a specific tag/version rather than 'latest'? .. since there were a couple breaks already in the past couple months.

[arthurdm]

I think the best thing would be to create a test framework that included complex sample such as batch, so that we stop breaking things. :)

[arthurdm]

@gmarcy - I believe a test framework for tWAS is a much needed addition.