was-node-suite-comfyui icon indicating copy to clipboard operation
was-node-suite-comfyui copied to clipboard

Incompatibility with ComfyUI front-end >11.8

Open SRagy opened this issue 11 months ago • 5 comments

A number of people have reported that WAS node suite causes ComfyUI to get stuck in an eternal loading loop for later versions of the ComfyUI front-end: https://github.com/comfyanonymous/ComfyUI/issues/7329

I've experienced this issue and removing the WAS nodes folder from the custom_nodes directory did fix it for me.

I'm not sure how to debug this because no error messages are served, it just never loads.

SRagy avatar Apr 06 '25 17:04 SRagy

Do you have any sources? Maybe they have better reports to offer. I can't reproduce this on the latest UI, on Windows, Linux, or Mac (VM), so sounds like conflict with another custom node.

This could be related to changes @robinjhuang made to toml effecting users installing from comfy CDN. I only install directly from GitHub, or with Manager in case of Mac where I just loaded up a workflow and let manager install missing.

WAS-NS doesn't even have any front-end mechanisms. It's back-end only with zero JS. So would be odd the UI would have any issues. Now other nodes using JS and not exclusively managing their own nodes and effecting others subsequently could be another issue. I don't like ComfyUI's FE system at all so besides clients I won't ever include JS in my nodes.

WASasquatch avatar Apr 06 '25 17:04 WASasquatch

Installing from registry shouldn't affect anything unless there is a problem during the packaging step.

Would be good to see a repro.

robinjhuang avatar Apr 07 '25 22:04 robinjhuang

Seems to actually be a conflict between this and DTAIComfyVariables that can now lead to ComfyUI getting stuck loading.

If removing either Was-node-suit or DTAIComfyVariables then ComfyUI returns to loading normally, but sadly not with both.... at least not anymore at this time, unless you roll back to front-end v11.8 or lower.

Major bruh moment.

Jatts-Art avatar Apr 23 '25 23:04 Jatts-Art

I have latest front end without issues, but do not DTAIComfyVariables. However, looking at the custom node, nothing in it should cause problems the same as mine. This seems to be niche conflicts with front end itself.

On Wed, Apr 23, 2025, 4:49 PM Jatts @.***> wrote:

Jatts-Art left a comment (WASasquatch/was-node-suite-comfyui#567) https://github.com/WASasquatch/was-node-suite-comfyui/issues/567#issuecomment-2825788753

Seems to actually be a conflict between this and DTAIComfyVariables https://github.com/yolanother/DTAIComfyVariables/issues/6#issue-2957424909 that can now lead to ComfyUI getting stuck loading.

If removing either Was-node-suit or DTAIComfyVariables then ComfyUI returns to loading normally, but sadly not with both.... at least not anymore at this time, unless you roll back to front-end v11.8 or lower.

Major bruh moment.

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/567#issuecomment-2825788753, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZEZIKHZOVHGIQENYTRN323ARHBAVCNFSM6AAAAAB2R5BULOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRVG44DQNZVGM . You are receiving this because you commented.Message ID: @.***>

WASasquatch avatar Apr 24 '25 03:04 WASasquatch

That being said, yeah I don't think these issues relate to your plugin directly at all (as you've mentioned earlier).

As for DTAIComfyVariables, it doesn't seem like its loading properly at all now even if its the only custom node installed... so its gotten even worse compared to last month. At least on my end.

Jatts-Art avatar Apr 24 '25 12:04 Jatts-Art