RadioConsole2 icon indicating copy to clipboard operation
RadioConsole2 copied to clipboard

[feature] Compile for macOS

Open RdWing opened this issue 8 months ago • 6 comments

Can this Electron app be easily compiled for macOS?

RdWing avatar Apr 16 '25 02:04 RdWing

Theoretically this is possible however hasn't been tried. I don't have a Mac machine handy to compile it with. You could compile it yourself fairly easily if you feel technically adept (just a few commands in the terminal).

nyaaaaaaatalie avatar Apr 16 '25 03:04 nyaaaaaaatalie

It's a little bit more than that, but I think it can be very easily added to the existing Github Actions workflow, instead of having to set up an entire dev environment for Electron locally here. I hate electron.

https://medium.com/@johnjjung/building-an-electron-app-on-github-actions-windows-and-macos-53ab69703f7c

RdWing avatar Apr 16 '25 05:04 RdWing

Image So, it sort of works. Am able to get it open, but get these errors.

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'UseAGC') at readConfig (client.js:1300:53)

client.js:1359 Uncaught (in promise) TypeError: Cannot set properties of undefined (setting 'UseAGC') at saveConfig (client.js:1359:25) at readConfig (client.js:1290:26)

And, I'm not able to add a radio.

client.js:1415 Uncaught TypeError: Cannot read properties of undefined (reading 'push') at newRadioAdd (client.js:1415:19) at HTMLButtonElement.onclick (index.html:445:107)

Manually replacing the config.json with a known working fixes that, will test and see if the rest works.

Image

RdWing avatar Apr 16 '25 05:04 RdWing

that's #18, a separate issue

I'll have to look into adding the macOSX build action. Maybe @nyaaaaaaatalie can take a look since she helped update them?

W3AXL avatar Apr 20 '25 03:04 W3AXL

I believe I fixed this. I put a fork in with my fix (that works as far as I can tell, I don't have a radio connected to my daemon to test it but everything seems to function properly). It boiled down to MacOS having slightly different syntax for IPC (I guess, I'm still not 100% sure lol) and would write the IPC output to config.json rather than defaultConfig. Should be fixed now though.

luckycxr avatar Jun 22 '25 17:06 luckycxr

@RdWing can you confirm the changes from @luckycxr solve your issue? If so I will approve the PR and set up an automatic OSX binary build for the console.

W3AXL avatar Jun 26 '25 21:06 W3AXL