[BUG] The latest version of Proton-GE is reinstalled even though it is already the latest version. ProtonPlus v0.5.12

[Mereo]

Describe the bug

After installing Proton-GE Latest, ProtonPlus v0.5.12 reinstalls Proton-GE Latest every time it is opened, even though it is already installed and is the latest version. This means that I have to put the user_settings.py file back every time I reopen ProtonPlus.

To Reproduce Steps to reproduce the behavior:

1. Open ProtonPlus
2. Install Proton-GE Latest,
3. Close ProtonPlus
4. Go to /home/USERNAME/.local/share/Steam/compatibilitytools.d/ with a file manager
5. Open ProtonPlus,
6. go to /home/USERNAME/.local/share/Steam/compatibilitytools.d/ with a file manager, you will see it reinstalls it even though it is already the latest

Expected behavior If it is Proton-GE Latest is already the latest, it shouldn't be reinstall it.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Manjaro
• DE: KDE Plasma 6.3.6
• Type: Flatpak

Additional context Add any other context about the problem here.

[Kishi85]

Seeing the same thing and it always installs GE10-12 instead of latest GE10-13.

[TerohsLab]

Seeing the same thing and it always installs GE10-12 instead of latest GE10-13.

It installs the 10-13 its just that GE goofed up the version showing in mangohud again. Its a semi common thing.

If you go into comptools -> ge-latest and open the file called "proton" in a texteditor you can see 20 lines from the top that its 10-13. Its just a display bug.

This may also be why ProtonPlus keeps redownloading it. Because the file "VERSION" shows 10-12 even tho its actually 10-13.

[Kishi85]

Ahh I see, well then that could also explain why it is updating all the time.

[Vysp3r]

I'll give it a look when I arrive home in a few hours.

I am indeed using the VERSION file to check if it should update or not so that would probably be the cause of the error.

Is there a reason why that file was not updated with the update?

[TerohsLab]

My assumption is that something in the build process is sometimes pulling it wrong into the zipped version. Because the VERSION file on github is correct.

You might need to talk to GE about that, because its not the first time and will not be the last time this happened.

[TerohsLab]

It happened again :D

[Vysp3r]

I saw, but like I said I am very busy right now so it will have to wait during my Christmas leave.

[Vysp3r]

@TerohsLab Hey, I have a bit of free time this weekend so I thought fixing this issue could be a good idea.

I think I will simply add a file that store the tag of the downloaded version and when I check for the update I simply check if the latest tag is different and if yes I download the new version. That way I don't rely on the version file and the tags can never be the same so it should fix that issue.

[TerohsLab]

I would leave your current version checking like it is and just add a failsave if your tool checks the VERSION file and finds a version with a git string at the end ( some regex magic prolly ).

If it find a crangled VERSION, make it check https://github.com/GloriousEggroll/proton-ge-custom/blob/master/proton this file for

CURRENT_PREFIX_VERSION="GE-Proton10-24"

I'm pretty sure this string has always been correct even if a crangled VERSION file is in the downloaded zip file.

[Vysp3r]

I made it so if the title in the version file or the proton file is equal to the latest tag it says there's no update. That should hopefully fix this issue.