Denis Vasilyev

Results 93 comments of Denis Vasilyev

More colors for the glory of ELKS Paint! ![Image](https://github.com/user-attachments/assets/d0a2e9e0-6bcb-4bf8-b333-599051360ba5)

@ghaerr, I found some bug in flood fill, but I have no idea what is going on in this function. If you apply this diff: ``` diff --git a/elkscmd/gui/app.c b/elkscmd/gui/app.c...

> Try increasing FLOOD_FILL_STACK to a larger number. Increasing to 200 helped. What I couldn't achieve is some kind of graceful exit from the function. Paint might work ok after...

I've spent a fair bit of time exploring various flood fill algorithms. The effort paid off: I achieved a 3× speed improvement. Benchmark of the original `R_LineFloodFill` in MartyPC: ```...

> Is the FrontFill PDF paper available anywhere? I guess I can put it here. [burtsev1993 An efficient flood-filling algorithm.pdf](https://github.com/user-attachments/files/20016210/burtsev1993.An.efficient.flood-filling.algorithm.pdf)

> What do you think? I’ll open a PR later today—once that’s in, we can better assess whether readpixel is the actual performance bottleneck. I don’t have any profiling data;...

> Well, readpixel has to loop through each of four planes to get the pixel color, of which I'm not sure we can get around. ChatGPT suggests to either keep...

> a simple optimization to cache 8 pixels at a time when you read a byte from each plane would mean only 1/8 calls to readpixel would be slow assuming...

@ghaerr something strange is going on with colors in MS Paint as can be seen in the video above and in the screenshot: ![Image](https://github.com/user-attachments/assets/0c0a5957-83c8-4965-83ba-c5b35e53b83f) It doesn't distinguish brown and dark...

> > UPDATE: What I am doing here is opening export.bmp generated by ELKS Paint in MS Paint > > Is this in MartyPC again? > > i'd check the...