Vulcan
Vulcan copied to clipboard
update ui-material datatable to withMulti2
After upgrading to the withMulti2
HoC I add the Datatable's input to listOptions
, including the search query
Please note that orderBy
and terms
were removed, so this might be a breaking change for some users
My apologies in advance for upgrading the HoC instead of refactoring it to hooks
Is there anything blocking this PR? If this works ok in your app I'll merge.
Is sorting still ok since orderBy
is removed as you said?
did try sorting yet, but again - this is a breaking change!
I am using it on my production app, but would love if you'll test it before merging
I don't really have any environment to test so that's why I prefer to "blind merge" if you run it in production already. The breaking change is ok here, old versions of "multi" etc. are deprecated anyway. I'll wait for some bugfixes to be merged though, but then we can merge safely.
Maybe @ErikDakoda is this change fine for your applications?
@yairtal you might want to also update the "MIGRATING" documentation too then with this breaking change
Hello, @yairtal and @eric-burel! My recommendation is that you commit the updated Datatable component as a new Datatable2 component and let each dev migrate to it at their own pace.
I just checked my code and I have 101 addView()
statements in my codebase that need to be migrated to inputs
. I feel that we need to give people a longer migration window.
Should be useMulti2
.