Vulcan icon indicating copy to clipboard operation
Vulcan copied to clipboard

Cannot query documents without limit using multi2

Open EloyID opened this issue 4 years ago • 1 comments

Before we could query all the documents setting limit = 0 in our query.

Nevertheless, this line https://github.com/VulcanJS/Vulcan/blob/3589018d353ea17f3a3ef96fd74581da393f0afe/packages/vulcan-core/lib/modules/containers/multi2.js#L50 causes limit fallback to 20 (the default value)

const defaultInput = { limit: 20, enableTotal: true, enableCache: false, };

Is this intended to happen or just a regression ? :)

EloyID avatar Jun 29 '20 14:06 EloyID

Probably a regression.

We probably should test typeof foo.limit === "undefined", so both limit:null and limit:0 allow to bypass the limit.

eric-burel avatar Jun 29 '20 14:06 eric-burel