vue-datepicker icon indicating copy to clipboard operation
vue-datepicker copied to clipboard

DO NOT deprecate `@time-picker-open` & `@time-picker-close` (overlay-toggle Is not a substitute)

Open alexchexes opened this issue 9 months ago • 3 comments

I just wanted to point out that, despite the docs say that we should use @overlay-toggle instead of @time-picker-open and @time-picker-close, @overlay-toggle does not provide a way to determine whether we have completely exited time-picker mode (returning to the date-picker) or if we are still in time-picker mode but have only closed the hours/minutes overlay.

I mean, the @overlay-toggle callback reports the same data: { overlay: 'hours', open: false } in both scenarios:

  1. When we close the time-picker completely while in the hour-overlay.
  2. When we simply close the hour overlay while still in time-picker mode.

In contrast, @time-picker-close is only triggered when we fully close the time-picker overlay, regardless of whether we were in the hours or minutes overlay.

alexchexes avatar Mar 09 '25 19:03 alexchexes

This is a bug then

Jasenkoo avatar Apr 08 '25 22:04 Jasenkoo

Stale issue message

github-actions[bot] avatar Jun 08 '25 03:06 github-actions[bot]

Any chance it will be resolved in the near future?

alexchexes avatar Jun 08 '25 03:06 alexchexes