ibeam icon indicating copy to clipboard operation
ibeam copied to clipboard

update docker compose

Open 0guanhua0 opened this issue 1 year ago • 3 comments

ref: https://docs.docker.com/compose/intro/history/#docker-compose-cli-versioning

https://github.com/compose-spec/compose-spec/blob/main/spec.md#compose-file

test:

guanhua@arch ~/ibeam (git)-[guanhua/update-docker] % sudo docker compose up -d

guanhua@arch ~/ibeam (git)-[guanhua/update-docker] % sudo docker compose logs -f

guanhua@arch ~/ibeam (git)-[guanhua/update-docker] % curl -X GET "https://localhost:5000/v1/api/portfolio/accounts" -k

0guanhua0 avatar Sep 26 '24 18:09 0guanhua0

this commit try to update to docker compose v2. v1 work but no longer supported.

0guanhua0 avatar Sep 26 '24 19:09 0guanhua0

My apologies, I wasn't even aware of the V2! Let me try this code when I find a minute and review it properly.

I'm still standing with my comment regarding the docker compose logs, so would you be okay to remove it in the meantime?

Voyz avatar Sep 26 '24 19:09 Voyz

yes i'm fine. i agree we should have clean code. but we should also consider non-tech users

0guanhua0 avatar Sep 26 '24 19:09 0guanhua0

Hey @0guanhua0 I've just managed to verify that this PR works fine. I appreciate your contribution and most of all for your patience when exposed to my ignorance on the Docker Compose v2. Thank you for filling in my gaps in knowledge and for this great contribution 👏

Voyz avatar Oct 30 '24 12:10 Voyz