Results 348 comments of voyz

Thanks for the explanation. You say: > For simplicity it is looking for a "truthy" value (non-zero or True) But reading the code, I think it tries to assure that...

Hey @weklund great suggestions all across the board 👏 Let me address them: > Establish Clear Test Patterns. Implement a standard pattern for our unit and integration tests. As in...

Great writeup @weklund and I appreciate that you challenge my existing approach 🙌 I've reflected on it and can see where I got some things wrong. More concretely though: >...

Let's reflect that if `my integration` & `my unit` -> `your unit tests`, while `my e2e` -> `your integration tests`, then in that write up you did on why we...

> Now I really did not want to use AI for this illustration, but I hope it proves the point (some of these are pretty pedantic) that we can use...

I read and agree to pretty much everything else you wrote, thanks for giving your thoughts 👍 If you could, let's loop back to whether rewriting everything in `pytest` would...

> it would be intentional to set our coverage goal at 90-95% line coverage Unless I'm mistaken, we'd still aim for 100%. The `# pragma: no cover` makes code blocks...

hey @weklund just wanted to follow up on this - it would be awesome if we could make some progress here with tests 👍

Hey @weklund thanks for sharing your thoughts on this. I appreciate you helping me understand your view here. Yeah, I think I'd feel uncomfortable publishing it at 68% - let's...

@weklund thanks for this detailed proposal! I'm open to introducing Pytdantic, but as always - there seems to be arguments on both sides so... let's discuss 🚀 A couple of...