voyz
voyz
I'm going to close this Issue as it is now fixed in `voyz/ibeam:0.5.4`. Let me know if you'd like to reopen it and continue the discussion. Thanks for contributing 👍
Hey @teodorkostov thanks for submitting this PR. I've spent a while reviewing the idea behind your proposed changes - one of having the dependency as latest each time we build....
As for: > Add 172.* addresses to whitelist 172.* addresses include both private and public IP addresses, hence hard-coding them as allowed seems to be a security risk and is...
Guys, firstly, I wanna say that I value your input and I'm open to this discussion. Nevertheless, I feel I'm missing a crucial point here, and I'd appreciate if you...
@demircancelebi thanks for pointing the security out 👍 Correct me if I'm wrong though: if my account gets compromised, a bad actor could introduce malicious code irrespectively of which method...
Hey @teodorkostov thanks for your reply. I wanted to give some time for other users to participate and reply to the points I brought up. However, seeing that there hasn't...
Hey @demircancelebi thanks for pointing this out and for your suggested fix 👍 I'm trying to debug this, what Python version are you running this on?
@demircancelebi just wanted to bring this PR back to your attention so that we could merge it
Many thanks for adjusting it, and for the contribution 👍
Hey @zacciep thanks for pointing it out. I've modified the `make_order_request` as per your suggestions. I'll publish it with the next minor release. As for the `live_market_data` - I'm sorry...