minecraft-launcher-core-node icon indicating copy to clipboard operation
minecraft-launcher-core-node copied to clipboard

Compatibility with legacy level

Open ci010 opened this issue 2 years ago • 3 comments

@John-Dean The PR #250 has some breaking change to the legacy region (1.14.4 1.12.2) format. Currently, I skip the tests to pass the build.

See github action https://github.com/Voxelum/minecraft-launcher-core-node/actions/runs/3919028110/jobs/6699776543 result.

If you have time you can take a look, I might pick up this item when I have time later.

ci010 avatar Jan 24 '23 13:01 ci010

Apologies, not too well at the moment (managed to catch the flu).

I've looked into this and basically we need to detect the version (pre 1.16) and then run a different function on it, see here: https://github.com/spoutn1k/mcmap/blob/fec14647c600244bc7808b242b99331e7ee0ec38/src/chunk_format_versions/section_format.cpp#L6

Currently the code is using the post 1.16 function, we need to implement the pre 1.16 and then version detect and select the correct one.

I'll look at this in a week or two when I'm feeling 100% again, but if you can get to it sooner that would be great.

John

John-Dean avatar Feb 01 '23 10:02 John-Dean

https://github.com/Voxelum/minecraft-launcher-core-node/pull/255

John-Dean avatar Feb 04 '23 18:02 John-Dean

I just checked-in a big refactor on all packages. The @xmcl/world is merged to @xmcl/game-data package. The major breaking change is I remove the dependency of Long. Now we use native bigint to handle the Long. Currently, it's lack of test. If you have any finding please let me know.

ci010 avatar Apr 14 '23 02:04 ci010