MobileUO
MobileUO copied to clipboard
VoxelBoy
Cannot launch using latest client files
Trying to launch using the latest client files but I receive an error NullReferenceException related to ReplaceUopGroup.
With the 7.104 patch broadsword changed some of the files which broke all the 3rd party clients. Yep the changes to classicuo to allow for the new files to be read are not present in mobileuo. So until someone updates mobileuo to basically the newest classicuo files the. 103 files are the last ones it can read
Thanks for the info. Any idea what the level of effort is to update from the latest ClassicUO? It looks like this repo wasn't forked and subtree wasn't used, so its fairly difficult to see what changes to the CUO code were made, if any.
@ptgeorge There some commits in the history like this one fc7cf4bf0b31516481f24f37c61e219229d23f40 that say "Updating to latest CUO". Looking at the date of the commit and the history of the ClassicUO repository, it would be possible to find out which ClassicUO commit that MobileUO has been "stuck" at. Then it would be quite a big effort of upgrading the entire, somewhat modified copy of ClassicUO within MobileUO to the latest. It could also be possible to cherry pick just the changes necessary to load the latest client files but that would require a good deal of familiarity with both codebases. I don't have the time to do it anymore for free.
Thanks. This is really helpful. I’ll take a look at some point and see what kind of drift there is. I might be able to take it on.
It looks like this is the closest CUO commit: https://github.com/ClassicUO/ClassicUO/tree/303c2ae699ca02caa6b09fbe5fbcb0c92f8bbd68
Doing a diff and reviewing looks to be changes made for MobileUO that aren't in CUO. A lot can happen in 4 years 😁 There's definitely been a lot of restructuring in CUO so as you said, @VoxelBoy , its a lot to bring MobileUO up to the latest.
@VoxelBoy I’ve opened #25 to make it easier for me to identify the MobileUO modifications to CUO code. Feel free to review, but it’s definitely not urgent. I just didn’t want to include that sort of content in a PR while actually making updates of CUO.
Very nice @ptgeorge. I've merged your PR. A quick look at the diff seems to show that a lot of the changes can be minimized between the two versions of the ClassicUO src. Might be a good first step before attempting to update ClassicUO to latest.
Thanks! I’ll see if I can reduce the changes made to CUO within MobileUO. I’ve already been going down a few different routes to see how to integrate the latest changes. It’s some work but eventually I’ll probably work it out.
To fully modernize, the Assistant work within MobileUO will likely be the most difficult, as “Packet” no longer exists within CUO.
@VoxelBoy Do you know what the original source was for XNAEmulator? Was it https://github.com/mvi/UnityXNA/ or some other repo?
@ptgeorge I didn't pull it in from a public repo, a kind person (whose handle I don't remember atm) on the ClassicUO Discord gave me his implementation at the time, which could have been based on a public repo like the one you linked at but I don't know for sure..
Thanks! I’ll see if I can reduce the changes made to CUO within MobileUO. I’ve already been going down a few different routes to see how to integrate the latest changes. It’s some work but eventually I’ll probably work it out.
To fully modernize, the Assistant work within MobileUO will likely be the most difficult, as “Packet” no longer exists within CUO.
What are you thinking for the best way to try and bring MobileUO up to the latest version of CUO? A big bang of 4 years of updates looks so unwieldy to me.
Probably by updating the classicuo copy inside mobileuo from one large refactor to another through classicuo's git history while making sure it's still working.
To help familiarize myself with the project and see the scope of changes between MobileUO and ClassicUO, I made a list of all the differences between the two projects here: https://github.com/mandlar/MobileUO/wiki/MobileUO-changes-from-ClassicUO
As next steps, I'll try and reduce some of these changes before trying to roll forward with ClassicUO updates in chunks.
Nice. FYI, I did start some various experiments in my fork: https://github.com/ptgeorge/MobileUO
Not sure if my latest is up there or not. It’s been a couple of weeks since I’ve looked at it. The assistant stuff probably needs to be temporarily stripped away just to at least get a minimal modern build up.
“diff -r” with various filtering is what I was using to compare.
I opened a PR to further reduce changes from ClassicUO and symlink some more files.
https://github.com/VoxelBoy/MobileUO/pull/26