MobileUO icon indicating copy to clipboard operation
MobileUO copied to clipboard

[CS] SoundsLoader: Fix missing music issue

Open hubertwang opened this issue 1 year ago • 3 comments

Hi @VoxelBoy,

I slightly modified patch from ClassicUO repo (issue). ClassicUO used a new path utility that's not exist in this repo, so I used UOFileManager.GetUOFilePath to find path to Music folder.

Please help to review this PR, thanks.

hubertwang avatar Aug 08 '24 10:08 hubertwang

Latest SoundsLoader.cs code can be found here

hubertwang avatar Aug 08 '24 10:08 hubertwang

Hi @hubertwang, did you test this in the Unity Editor or a build that this fixes the issue and music plays in-game?

VoxelBoy avatar Aug 12 '24 12:08 VoxelBoy

Hi @hubertwang, did you test this in the Unity Editor or a build that this fixes the issue and music plays in-game?

Yes, I tested it with my iPhone, but I dont have a android device, havent tried it in android yet.

Should we release it to tesflight?l or android beta? More ppl join the test can increase the confidence level.

hubertwang avatar Aug 12 '24 12:08 hubertwang

Just a FYI but this appears to be in someway loading the music incorrectly. For example, UOAlive includes music with its download and all the music plays the same (incorrect) file. I'll take a closer look at it later once I get CUO version caught up, it might get resolved with CUO upgrades.

mandlar avatar Jan 08 '25 02:01 mandlar