VoxelBotUtils icon indicating copy to clipboard operation
VoxelBotUtils copied to clipboard

Allow "database" in config for mysql connections

Open 4Kaylum opened this issue 3 years ago • 5 comments

Aiomysql requires "db" instead of "database". VBU should allow both.

4Kaylum avatar Jan 22 '22 02:01 4Kaylum

Aiomysql requires "db" instead of "database". VBU should allow both.

I will try my best to see what I can do for that

Crafter-san avatar Mar 08 '22 02:03 Crafter-san

@4Kaylum when you're awake, please elaborate on which part it requires "database". Are you talking about item names in objects sent to the API? or are you talking about variables?

Crafter-san avatar Mar 08 '22 02:03 Crafter-san

The current VBU config file takes in database connection options with the "database" key. The "db" key should be considered an alias/alternative to this key.

If both are supplied, which one should take over the other?

sn8to avatar Mar 09 '22 18:03 sn8to

The current VBU config file takes in database connection options with the "database" key. The "db" key should be considered an alias/alternative to this key.

If both are supplied, which one should take over the other?

Ideally, the last one that is defined in a file so they would overwrite each other but maybe "database" if checking for the last one in a file is not a possibility as "database" is just longer and more noticeable in a large configuration file.
I would love to know what your opinions are and the justifications behind those opinions

Silverdimond avatar Mar 09 '22 18:03 Silverdimond

honestly the config should just stay as only allowing "database" and just parse it differently for msql connections

4Kaylum avatar Mar 09 '22 18:03 4Kaylum