Novus icon indicating copy to clipboard operation
Novus copied to clipboard

Add method for getting partial message from url to Client

Open AustinRJakusz opened this issue 2 years ago • 1 comments

Summary

Closes #1

Added get_partial_message to client which allows getting a PartialMessage object from a URL or Channel ID & Message ID combination.

I decided to not except the possible exceptions from fetching the channel to allow for developers to implement their own exceptions based on their use case. I have also tested this with Threads so all should be good.

Checklist

  • [x] If code changes were made then they have been tested.
    • [x] I have updated the documentation to reflect the changes.
  • [x] This PR fixes an issue.
  • [x] This PR adds something new (e.g. new method or parameters).
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • [ ] This PR is not a code change (e.g. documentation, README, ...)

AustinRJakusz avatar May 05 '22 05:05 AustinRJakusz

Ideally I'd like this changed to a non-async method. All of our get_partial_* methods should be usable without making an API call. That's really the point of them.

4Kaylum avatar Jun 24 '22 19:06 4Kaylum