vowpal_wabbit icon indicating copy to clipboard operation
vowpal_wabbit copied to clipboard

metrics namespace per reduction

Open lalo opened this issue 2 years ago • 3 comments

Short description

Force reductions to only add metrics in their own namespace. The metrics output dictionary should then be some sort of dictionary[reduction_name_str, dictionary]

Possible solution/implementation details

It can be enforced at learner.h, before calling into the func pointer of persist metrics. You create a new namespace based on the name of the learner and its just a dictionary in json terms (metrics.cc)

Example/links if any

https://github.com/VowpalWabbit/vowpal_wabbit/blob/1098efd3e67d1ad913bec1712e6bc52074f884a3/vowpalwabbit/core/include/vw/core/learner.h#L488

lalo avatar Feb 14 '23 21:02 lalo

I want to take this up. I will submit a PR after playing around and testing the patch thoroughly (roughly 1-2 days).

freyam avatar Feb 15 '23 10:02 freyam

@lalo I am new to the community but this project seems interesting to me. And I believe this could be a good first issue for me to solve. Can you assign this to me?

adityakanu avatar Feb 16 '23 12:02 adityakanu

Cann you please assign this project .

Gauravmauryaios avatar Apr 01 '23 20:04 Gauravmauryaios