vowpal_wabbit icon indicating copy to clipboard operation
vowpal_wabbit copied to clipboard

option.replace misuse

Open lalo opened this issue 4 years ago • 1 comments

https://github.com/VowpalWabbit/vowpal_wabbit/blob/895d347d6426234eaf8ebf70ee63daefdec908ef/vowpalwabbit/cb_explore_adf_cover.cc#L236

option.replace seems to only replace the command line argument on the input list of string arguments m_command_line and not on the already parsed m_options

In the referenced code above, it seems like a possible misuse since it's not calling add_and_parse after adding it. Unless I'm missing something about the behavior.

lalo avatar Aug 06 '20 14:08 lalo

In the linked location the option in the command line is replaced with mtr and then the place where parsing had recorded the other value is overwritten with mtr as well. So I think it is working as intended

jackgerrits avatar Dec 03 '21 16:12 jackgerrits