C# bindings on .NET core 3.1

[marat-turaev]

PR for #2272:

• All *.csproj were converted to SDK-style to multitarget net452 and netcoreapp3.1
• vw_netcore.vcxproj netcore C++/CLI project was added to target netcoreapp3.1
• Streamlined VS2019 migration: MSVC v142 toolset & Windows SDK 10.0 now targeted
• Other minor improvements

[marat-turaev]

Currently this PR is blocked by two VS bugs:

https://developercommunity.visualstudio.com/content/problem/831275/dynamic-library-project-native-lib-dependency-link.html

https://developercommunity.visualstudio.com/content/problem/900965/vs-165-preview-20-problem-with-make-heap-unchecked.html

[marat-turaev]

Unblocking PR, as I worked around https://developercommunity.visualstudio.com/content/problem/831275/dynamic-library-project-native-lib-dependency-link.html with cb5e06c09fc7711b1cea2a62eca0e891e71943b5 and https://developercommunity.visualstudio.com/content/problem/900965/vs-165-preview-20-problem-with-make-heap-unchecked.html is non-repro on current (16.4) VS version

[thealphadollar]

@marat-turaev Any updates on this? I guess this is in pretty good shape for a re-review.

[marat-turaev]

@marat-turaev Any updates on this? I guess this is in pretty good shape for a re-review.

Yes, this PR is open for review.

[lokitoth]

Still working on reviewing this. Going to first see if I can understand what is causing Windows CI to fail.

[marat-turaev]

Still working on reviewing this. Going to first see if I can understand what is causing Windows CI to fail.

Due to this VS 16.5 bug: https://developercommunity.visualstudio.com/content/problem/900965/vs-165-preview-20-problem-with-make-heap-unchecked.html

It's fixed with 16.6, builds ok with preview version: https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes-preview

[lgtm-com[bot]]

This pull request introduces 6 alerts when merging 9846721cc4b5b5df948c793cc80572de8b9378aa into 19fda264aabb494daa48518c801b77247d06500a - view on LGTM.com

new alerts:

• 6 for Missing Dispose call on local IDisposable

[lgtm-com[bot]]

This pull request fixes 6 alerts when merging be2a5a110e9e4b17704be2223161bcd2482ca7f8 into fb8ca3c9cc887c24e4f17da6124be148d994bd93 - view on LGTM.com

fixed alerts:

• 6 for Missing Dispose call on local IDisposable

[leaomatheus]

Are there plans on merging this? I'd be also interested in it to enable .NET core support for a project that takes VW as a dependency.

[smiranda]

+1 interest

[lokitoth]

Closing as completed via #3969