reinforcement_learning icon indicating copy to clipboard operation
reinforcement_learning copied to clipboard

Fix wheels produced by CI

Open ataymano opened this issue 3 years ago • 4 comments

Currently wheel files produced by CI is not usable.

Tested on WSL2 Ubuntu 20.04 python 3.8.10

Running https://github.com/VowpalWabbit/reinforcement_learning/blob/master/examples/python/basic_usage.py hangs with the following outputs:

ataymano@ataymano-sb1:~/src/github/VowpalWabbit/reinforcement_learning/examples/python$ python3 basic_usage.py
event_id: 032575ce-fc7a-4837-a8bb-517012c980f8
model_id: N/A
chosen action id: 1
all action probabilities [(1, 0.5), (0, 0.5)]
event_id: c8cf584c-ec46-4639-8ca9-545a6836d3cc
model_id: N/A
chosen action id: 1
all action probabilities [(1, 0.5), (0, 0.5)]
event_id: 10223fb5-8987-4908-8378-181d657efc46
model_id: N/A
chosen action id: 1
all action probabilities [(1, 0.5), (0, 0.5)]

And there is no data on server side - probably something is wrong with cpprest.

ataymano avatar Dec 20 '21 20:12 ataymano

I can try to take a look. Instead of CI, manual build should be working.

zwd-ms avatar Jan 27 '22 17:01 zwd-ms

Some observations:

  1. Verified that building wheel locally works on WSL2 ubuntu 20.04
  2. Using the CI-produced wheel, the program hangs due to stuck background threads never joining (observed in gdb)
  3. auditwheel tries to package dependencies from a centos docker image, including libssl, but it seems to have some binary incompatibility issues on ubuntu, causing the issue. I tried to replace some dependencies without much success.

zwd-ms avatar Mar 07 '22 18:03 zwd-ms

I wonder if it is possible to not bundle libssl. We should most likely be depending on the system copy right?

jackgerrits avatar Mar 07 '22 18:03 jackgerrits

yes agreed, so they can for example enjoy security updates.

zwd-ms avatar Mar 07 '22 18:03 zwd-ms