reinforcement_learning icon indicating copy to clipboard operation
reinforcement_learning copied to clipboard

Published 20 hours ago • verified publisher icon VowpalWabbit

Improve our windows build situation

Open kumpera opened this issue 4 years ago • 1 comments

Out current build story on windows needs some love.

The problem:

We currently have two build scripts for rlclientlib: cmake and msbuild. The CI coverage of the msbuild setup is not as throughout as the cmake one.

We should improve things by either eliminating the msbuild bits (while retaining a VS experience) or by improving our CI bits.

For CI, we don't build the dotnet bits using the msbuild scripts and this triggered a regression when zstd was introduced. It's fixed by https://github.com/VowpalWabbit/reinforcement_learning/pull/232 but CI should catch such trivial issue.

kumpera avatar Nov 23 '20 16:11 kumpera

This was partially improved in #320 and #332 (pending #335).

Remaining work here seems to be:

  • [ ] Migrate to CMake in Windows CI (should net us a nice time improvement too)
  • [ ] Deprecate non-CMake projects (need to figure out how to communicate this to downstream consumers)

lokitoth avatar Jun 07 '21 15:06 lokitoth