VoronUsers icon indicating copy to clipboard operation
VoronUsers copied to clipboard

Nozzle wiper by chirpy

Open waytotheweb opened this issue 2 years ago • 9 comments

  • [ x] The mod, firmware configuration or slicer profile is in the correct category folder. Printable mods go to printer_mods/, firmware configurations go to firmware_configurations/, slicer profiles go to slicer_profiles/. Create a subfolder with your name, and place the mods in a subfolder with a descriptive name within that folder, e.g.: /printer_mods/FHeilmann/flux_capacitor
  • [x ] Folders names MUST NOT contain spaces. If possible, make sure file names also do not contain any spaces.
  • [x ] For each mod, add a small README.md file to its folder with a short description of what the mod accomplishes. This readme can be used to add pictures, give assembly instructions or specify a bill of materials if the mod requires additional hardware.
  • [ x] The PR modifies the top-level README.md of the category folder adding the contribution to the table. Read the top part of the file for instructions on how to do this. Please preserve the alphabetical ordering while adding new rows. Make sure to fill out the compatibility matrix to indicate which versions of the Voron printer the submission is compatible with.
  • [x ] The mod/configuration/profile has been tested by the person submitting the mod and/or other Voron users. Make sure to add information about how the mod was tested below.
  • [x ] The mod is not merely a slight modification of an official Voron part, configuration or profile (i.e. an official Voron part with a few mm added or removed or a slicer profile which only modifies a few values). (When in doubt, contact one of the admins in the Voron discord before submitting the PR)
  • [ x] Submitted STLs are printable without support. (If the mod does not meet this criterion join the Voron discord and ask the other users for advice on how to modify the mod such that it does not require supports)
  • [x ] Submitted STL files are not corrupt. (This can be tested by opening the STL in PrusaSlicer and checking if mesh errors are reported.)
  • [x ] Submitted STL files are oriented and scaled properly for printing.
  • [x ] Submission includes a CAD file in the form of a .STEP or .SCAD file
  • [x ] Submitted firmware configs or slicer profiles contain no sensitive data (e.g. API keys).

Which mods/configurations/profiles are added by this PR?

chirpy/NozzleWiper

How was it tested?

printed out and fitted to a V0.1 and used for several weeks

Any background context you want to provide?

none

Screenshots (if appropriate)

included in repo

Further notes

none

waytotheweb avatar Jul 11 '22 17:07 waytotheweb

LGTM

MapleLeafMakers avatar Jul 19 '22 00:07 MapleLeafMakers

I've converted this to draft temporarily as I want to make a few more checks on the parts. Sorry for the delay, but I'd rather do this now rather than have to submit a new PR after it's published. I should be done checking within the next 24 hours.

waytotheweb avatar Jul 24 '22 21:07 waytotheweb

@waytotheweb take your time, it's no problem at all.

MapleLeafMakers avatar Jul 25 '22 01:07 MapleLeafMakers

OK. I've tidied up what I wanted to and am happy if this can proceed.

waytotheweb avatar Jul 25 '22 14:07 waytotheweb

Gah! Serves my right for changing things. I've pushed fixed STL's.

waytotheweb avatar Jul 25 '22 16:07 waytotheweb

I went ahead and made the changes to try to resolve the README.md issue. I tried various combinations, but none seem to resolve the conflict, so I don't know if there's more you need me to do.

waytotheweb avatar Jul 27 '22 07:07 waytotheweb

In order to resolve the conflicts, you branch needs to have the latest changes pulled into it, there's a guide here that should help: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Backing up your files, and then creating a new PR from a new branch after updating your master branch would be the 'nuclear' option, that'll work too.

MapleLeafMakers avatar Jul 27 '22 12:07 MapleLeafMakers

Just merged in upstream and fixed README.md - hopefully :)

waytotheweb avatar Jul 27 '22 14:07 waytotheweb

Looks good!

MapleLeafMakers avatar Jul 27 '22 21:07 MapleLeafMakers