VoronUsers icon indicating copy to clipboard operation
VoronUsers copied to clipboard

Decontaminator nozzle_clean script has a bug that affects right-side mounted brush/buckets.

Open LoganFraser opened this issue 2 years ago • 8 comments

The last X move in the nozzle_clean script is as follows: G1 X{bucket_left_width / 4} F{prep_spd_xy}

But for a right side mounted bucket, the line needs to be G1 X{bucket_start + (bucket_left_width / 4)} F{prep_spd_xy}

This should also work fine with left side mounted buckets.

@edwardyeeks

LoganFraser avatar Feb 19 '22 21:02 LoganFraser

I can confirm this fix worked for me

nknotts avatar Feb 22 '22 14:02 nknotts

You should explain what the bug is, I have a right sided mount bucket and I'm not sure what this is supposed to fix as I have no issues

rogery555 avatar Feb 27 '22 17:02 rogery555

The intention of the final X move is to move to just inside the left edge of the left side of the bucket, and does so for a left-side mounted bucket, but crashes the nozzle into the klicky dock if using a right-side mounted bucket. The replacement line adds in the bucket offset from X0 so it correctly moves to inside the bucket for a right side mount.

LoganFraser avatar Feb 27 '22 19:02 LoganFraser

I had the same behavior as @LoganFraser, the final move crashed the nozzle into my left-mounted klicky dock. With the replacement line, the final move parks the nozzle to the left edge of the bucket.

nknotts avatar Feb 27 '22 19:02 nknotts

Some context for the patch. Please confirm this is correct:

     ## Clear from area.
      M117 Cleaned!
      G1 Z{brush_top + clearance_z} F{prep_spd_z}

      {% if enable_purge %}

      ### BUG:  G1 X{bucket_left_width / 4} F{prep_spd_xy} 
      G1 X{bucket_start + (bucket_left_width / 4)} F{prep_spd_xy}


      {% endif %}

      ## Restore the gcode state to how it was before the macro.
      RESTORE_GCODE_STATE NAME=clean_nozzle

rlaferla avatar Mar 02 '22 19:03 rlaferla

Yes, that's correct.

LoganFraser avatar Mar 04 '22 02:03 LoganFraser

I just came to make the exact same issue request with the exact same solution. It works for me as well.

claudermilk avatar Mar 07 '22 18:03 claudermilk

Looks like this issue should be closed. :)

LongDono avatar Nov 08 '22 14:11 LongDono