VoronUsers icon indicating copy to clipboard operation
VoronUsers copied to clipboard

VOV0_ToolHead

Open Mamsih opened this issue 4 years ago • 7 comments

Re request

  • [ x] The mod, firmware configuration or slicer profile is in the correct category folder. Printable mods go to printer_mods/, firmware configurations go to firmware_configurations/, slicer profiles go to slicer_profiles/. Create a subfolder with your name, and place the mods in a subfolder with a descriptive name within that folder, e.g.: /printer_mods/FHeilmann/flux_capacitor
  • [ x] Folders names MUST NOT contain spaces. If possible, make sure file names also do not contain any spaces.
  • [ x] For each mod, add a small README.md file to its folder with a short description of what the mod accomplishes. This readme can be used to add pictures, give assembly instructions or specify a bill of materials if the mod requires additional hardware.
  • [x ] The PR modifies the top-level README.md of the category folder adding the contribution to the table. Read the top part of the file for instructions on how to do this. Please preserve the alphabetical ordering while adding new rows. Make sure to fill out the compatibility matrix to indicate which versions of the Voron printer the submission is compatible with.
  • [x ] The mod/configuration/profile has been tested by the person submitting the mod and/or other Voron users. Make sure to add information about how the mod was tested below.
  • [ x] The mod is not merely a slight modification of an official Voron part, configuration or profile (i.e. an official Voron part with a few mm added or removed or a slicer profile which only modifies a few values). (When in doubt, contact one of the admins in the Voron discord before submitting the PR)
  • [x ] Submitted STLs are printable without support. (If the mod does not meet this criterion join the Voron discord and ask the other users for advice on how to modify the mod such that it does not require supports)
  • [x ] Submitted STL files are not corrupt. (This can be tested by opening the STL in PrusaSlicer and checking if mesh errors are reported.)
  • [x ] Submitted STL files are oriented and scaled properly for printing.
  • [x ] Submitted firmware configs or slicer profiles contain no sensitive data (e.g. API keys).

Which mods/configurations/profiles are added by this PR?

yes

How was it tested?

yes

Any background context you want to provide?

no

Screenshots (if appropriate)

yes

Further notes

no

Mamsih avatar Oct 03 '21 11:10 Mamsih

Thanks KiloQubit for responding, BTW, don't know what is the easiest thing to download the file and put in the slicer, choosing the filament needed for HIT printing, this is the MOD users section , so many here know they need a bit of work, there are a lot of confirmed mods harder to build a voron 2.4 without XD documentation .. thanks again for your time and effort i will put it on my own Github / thingevers .. you can close it, i will give up XD..

Mamsih avatar Oct 03 '21 12:10 Mamsih

Thanks KiloQubit for responding, BTW, don't know what is the easiest thing to download the file and put in the slicer, choosing the filament needed for HIT printing, this is the MOD users section , so many here know they need a bit of work, there are a lot of confirmed mods harder to build a voron 2.4 without XD documentation .. thanks again for your time and effort i will put it on my own Github / thingevers .. you can close it, i will give up XD..

Thanks for your comment. While it is the usermods section, the goal for all mods here is to have the same printability as stock Voron parts. If you take a look around, you'll see that ALL mods here have that requirement, look at the reviews of other pull requests. It even says that in the pull request message you get when you create a pull request:

Screen Shot 2021-10-03 at 09 07 49

You're of course free to have this mod in your own github if you want, but if you do want it merged into the VoronUsers repo, it needs to meet the same requirements as the other mods. If you still want to modify your STLs to be printable without supports, I will be happy to review them. If not, that is unfortunate, but you can close the pull request with a button on the bottom.

KiloQubit avatar Oct 03 '21 13:10 KiloQubit

ok !

Le dim. 3 oct. 2021 à 15:12, KiloQubit @.***> a écrit :

Thanks KiloQubit for responding, BTW, don't know what is the easiest thing to download the file and put in the slicer, choosing the filament needed for HIT printing, this is the MOD users section , so many here know they need a bit of work, there are a lot of confirmed mods harder to build a voron 2.4 without XD documentation .. thanks again for your time and effort i will put it on my own Github / thingevers .. you can close it, i will give up XD..

Thanks for your comment. While it is the usermods section, the goal for all mods here is to have the same printability as stock Voron parts. If you take a look around, you'll see that ALL mods here have that requirement, look at the reviews of other pull requests. It even says that in the pull request message you get when you create a pull request:

[image: Screen Shot 2021-10-03 at 09 07 49] https://user-images.githubusercontent.com/69389593/135755002-b5f0d595-591b-461b-a0cd-1219ab03f7d5.png

You're of course free to have this mod in your own github if you want, but if you do want it merged into the VoronUsers repo, it needs to meet the same requirements as the other mods. If you still want to modify your STLs to be printable without supports, I will be happy to review them. If not, that is unfortunate, but you can close the pull request with a button on the bottom.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/VoronDesign/VoronUsers/pull/474#issuecomment-932948677, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQW3ISDUMJHNSW4T3IYN7W3UFBJFTANCNFSM5FHQWX6A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

Mamsih avatar Oct 03 '21 14:10 Mamsih

Added files with pre-support

Mamsih avatar Oct 05 '21 00:10 Mamsih

Why are there so many duplicate files? Two left fans, two right fans, etc. Can you either remove out of date versions, or put some explanation in the readme about what to print and what the different file are for?

cbc02009 avatar Oct 13 '21 21:10 cbc02009

I still see unexplained duplicate files and parts with lots of unsupported overhangs that will need to be corrected before this PR is accepted.

bdbell avatar Dec 03 '21 05:12 bdbell

@Mamsih do you want to clean this up and get it merged? You'll also need to add a .step/.scad file now.

newphreak avatar Jul 23 '22 13:07 newphreak

Closing due to inactivity.

cbc02009 avatar Aug 29 '22 22:08 cbc02009