vonage-node-sdk
vonage-node-sdk copied to clipboard
Add Conversations v0.1 Support
- Added support for Conversation API v0.1
- Removed
nexmo.users.getConversations
Codecov Report
Merging #282 into beta will decrease coverage by
0.4%
. The diff coverage is100%
.
@@ Coverage Diff @@
## beta #282 +/- ##
==========================================
- Coverage 71.29% 70.89% -0.41%
==========================================
Files 30 30
Lines 1087 1072 -15
==========================================
- Hits 775 760 -15
Misses 312 312
Impacted Files | Coverage Δ | |
---|---|---|
src/Events.js | 100% <100%> (ø) |
:arrow_up: |
src/Members.js | 100% <100%> (ø) |
:arrow_up: |
src/Conversations.js | 100% <100%> (ø) |
:arrow_up: |
src/Users.js | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 37366af...ad3d71d. Read the comment docs.
Yeah, it's a pass-through SDK. So changing the base URL is all that's needed. There's a minor removal of multiple API paths at the same time and removing the users.getConversations method.
Does anyone know if any of these changes are still valid after seven months?
There will be some changes when v0.3 drops here relatively soon. It's close to this v0.1, but some minor changes.
I believe that these changes were rolled into the beta branch which contains a combined set of changes for conversation, messages, and .... something else. These should have been separate branches IMO, releasing one of the beta featuresets and not another may be tricky with the current setup. This PR is outdated I think.
This is a separate Conversations implementation using the new spec, not what is currently in the beta branch