mrjs icon indicating copy to clipboard operation
mrjs copied to clipboard

create material utils to clone off of for cleaner setup

Open hanbollar opened this issue 1 year ago • 1 comments

Linking

related to #669

Problem

reduce number of overall programs and materials being used in a scene (reduce number of draw calls per renderpass)

Solution

temporary pass to reduce number of overall unique new materials - going to do a cleaner/bigger version of this when we add in a MaterialsManager to actually cache re-used materials better.

Breaking Change

nope

Notes

...


Required to Merge

  • [x] PASS - all necessary actions must pass (excluding the auto-skipped ones)
  • [ ] TEST IN HEADSET - main dev-testing-example and any of the other examples still work as expected
  • [ ] VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.
  • [x] TITLE - make sure the pr's title is updated appropriately as it will be used to name the commit on merge
  • [ ] BREAKING CHANGE
    • DOCUMENTATION: This includes any changes to html tags and their components
      • make a pr in the documentation repo that updates the manual docs to match the breaking change
      • link the pr of the documentation repo here: #pr
      • that pr must be approved by @lobau
    • SAMPLES/INDEX.HTML: This includes any changes (html tags or otherwise) that must be done to our landing page submodule as an effect of this pr's updates
      • make a pr in the mrjs landing page repo that updates the landing page to match the breaking change
      • link the pr of the landing page repo here: #pr
      • that pr must be approved by @hanbollar

hanbollar avatar May 18 '24 04:05 hanbollar

Your Render PR Server URL is https://examples-mrjs-pr-670.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cp42i9un7f5s739e2mm0.

render[bot] avatar May 18 '24 04:05 render[bot]

small - so merging

hanbollar avatar May 22 '24 21:05 hanbollar