Iris icon indicating copy to clipboard operation
Iris copied to clipboard

IOB Tile Entity Support

Open cyberpwnn opened this issue 3 years ago • 6 comments

This is actually very complex and will require a lot of testing but generally, this means that you can save Signs, Chests (with items in them) and Spawners to name a few and have them retain their data properly. There are multiple reasons why this is complicated but in general,

  • Iris generated with MCA is actually easy... just write NBT in the format MC needs
  • Bukkit Generated is harder because bukkit hides NMS and instead requires you to use the interfaces.

I think the best approach for this is to simply support one type of tile entity at a time. Yes... this means that if 1.17 adds a new tile entity, we will have to update to support it, but it is the most reliable way to do it. (same way world edit does, just without NMS)

cyberpwnn avatar Jan 12 '21 11:01 cyberpwnn

@StrangeOne101 Didn't you add this alr?

svdgoor avatar Jul 14 '21 21:07 svdgoor

Isn’t working correctly if I remember correctly

ghost avatar Jul 14 '21 21:07 ghost

We do have basic tile entity support. However, this doesn't include any container that can hold items and only supports NBT spigot has an interface for. Right now we support:

  • Signs
  • Banners
  • Spawners (vanilla mob types only)

But as @ArMiN231 said, tile entities aren't working in Jigsaw placements in 1.17. They are still supported with objects though as manually placing a pillager outposts will place it with the correct banners

If we want proper tile entity support, we WILL need to use NMS

StrangeOne101 avatar Jul 14 '21 22:07 StrangeOne101

@StrangeOne101 Has there been progress on this in the meantime?

svdgoor avatar Jul 25 '21 19:07 svdgoor

@StrangeOne101 Has there been progress on this in the meantime?

There has been no progress on this

StrangeOne101 avatar Aug 03 '21 02:08 StrangeOne101

Included with The Mantle #519

svdgoor avatar Aug 09 '21 15:08 svdgoor