go-trello icon indicating copy to clipboard operation
go-trello copied to clipboard

more card actions

Open fiatjaf opened this issue 8 years ago • 4 comments

fiatjaf avatar Feb 21 '16 02:02 fiatjaf

LGTM other than the minor questions/comments. Can you answer them pls? Thanks for your contribution!

VojtechVitek avatar Feb 22 '16 16:02 VojtechVitek

Please ignore the failing tests. They are fixed in another PR.

Also, @VojtechVitek, let me set the API key and token in the Travis repository, or perhaps you can set them yourself, with your account, by just joining the board: https://trello.com/b/iZVEfBeQ/go-trello-test-board

It's very annoying, but I am writing tests considering that the Board will be left the same way it was before the test suite was run. For example, if during the test you add a card, on a subsequent test case you have to delete that same card. I can't think of a better way to do it. @Luzifer what do you think of this approach?

It's dangerous that someone can create a test that doesn't meet this criteria and submit a PR, the test will be run by Travis and the board will be messed up.

fiatjaf avatar Feb 26 '16 01:02 fiatjaf

@fiatjaf can't we create new board for each test?

VojtechVitek avatar Feb 26 '16 15:02 VojtechVitek

That's a good idea, but I think this would configure an abusive usage, since Trello boards can't be deleted.

fiatjaf avatar Feb 26 '16 20:02 fiatjaf