Vojtech Vitek (golang.cz)

Results 235 comments of Vojtech Vitek (golang.cz)

Implemented in https://github.com/go-chi/httprate/pull/31. You can now omit all headers via: ```go httprate.Limit( 1000, time.Minute, httprate.WithResponseHeaders(httprate.ResponseHeaders{}), ) ``` You can also customize or omit individual headers: ```go httprate.Limit( 1000, time.Minute, httprate.WithResponseHeaders(httprate.ResponseHeaders{...

`IncrAndGet()` would increase the counter at all times, even if we respond with `HTTP 429 Too many requests`. We don't want that. We need to increase the counter only if...

Hi everyone, I've created a prototype for `github.com/go-chi/httplog/v3` and I'm seeking feedback. Here's the repo you can play around with: https://github.com/golang-cz/httplog It’s a brand new implementation that has `log/slog` in...

Hi @judofyr, see this message in the official `slog/log` [blog post](https://go.dev/blog/slog): > After two months and about 300 comments, we felt we were ready for an actual [proposal](https://go.dev/issue/56345) and accompanying...

@go-aegian I think it'd be fine to accept the new `func WithHeaders(on bool) Option {}`, though :)

Please see https://github.com/go-chi/httprate/pull/31. You can now omit all headers via: ```go httprate.Limit( 1000, time.Minute, httprate.WithResponseHeaders(httprate.ResponseHeaders{}), ) ``` You can also customize or omit individual headers: ```go httprate.Limit( 1000, time.Minute, httprate.WithResponseHeaders(httprate.ResponseHeaders{...

Hi @chance-schultz, This is an interesting feature request! The current `httprate` pkg does rate-limiting only at the beginning of the request, which makes sense. However I can imagine you could...

Hi @creack, I'm just looking into this PR and it looks good. Thank you! ~However, I think we should combine the changes with ideas from https://github.com/go-chi/httprate/issues/2, if we're to expand...

@creack I'm thinking about the pros/cons of passing the context timeout down to the networked-based limit counter(s). Few things to consider: - Would it be enough if we set a...