VivecraftMod icon indicating copy to clipboard operation
VivecraftMod copied to clipboard

little tiles redirect conflict

Open fayer3 opened this issue 1 year ago • 2 comments

little tiles crashes because of a redirect conflict, probably fixable with mixin extras

@Redirect conflict. Skipping littletiles.mixins.json:client.MinecraftMixin->@Redirect::isDestroying(Lnet/minecraft/client/multiplayer/MultiPlayerGameMode;)Z with priority 1000, already redirected by vivecraft.mixins.json:client_vr.MinecraftVRMixin->@Redirect::vivecraft$seatedCheck(Lnet/minecraft/client/multiplayer/MultiPlayerGameMode;)Z with priority 1000

https://github.com/CreativeMD/LittleTiles/blob/3b191a2e52bf96e979cb0cb3f1766841b77630df/src/main/java/team/creative/littletiles/mixin/client/MinecraftMixin.java#L89-L92

https://github.com/Vivecraft/VivecraftMod/blob/c1814bf0891bfdd5575ace7d00acd966af220f3a/common/src/main/java/org/vivecraft/mixin/client_vr/MinecraftVRMixin.java#L443

https://modrinth.com/mod/littletiles

fayer3 avatar Jun 03 '24 02:06 fayer3

Made use of MixinExtra's wrapper operator, which should hopefully fix this issue.

CreativeMD avatar Sep 13 '24 15:09 CreativeMD

#284 will replace all redirects with wrap operations which will also fix this

fayer3 avatar Sep 13 '24 16:09 fayer3

should be fixed with #284

fayer3 avatar Nov 29 '24 21:11 fayer3