VivecraftMod
VivecraftMod copied to clipboard
Vivecraft
Controlling a horse via the reins lack visual feedback.
In 1.12 it is obvious how your hands control the reins after you mount a house thanks to the "much better cosmetic display" introduced in 1.1.12 v5. Basically the rein where attached to your hands and not just the horse. Newer versions lack this visual feedback making controlling a horse confusing.
Originally reported against 1.16 and still and issue with 1.20: https://github.com/jrbudda/Vivecraft_116/issues/13
what is a rein?
what is used to control the horse in real life, see https://www.merriam-webster.com/dictionary/rein for an illustration
do you have a screenshot of what you mean?
not at the moment, but if you try and ride a horse in 1.12 it will become obvious what I mean
screenshot for reference
and code links
https://github.com/jrbudda/Vivecraft_112/blob/master/patches/net/minecraft/client/model/ModelHorse.java.patch
you only want the visual rein, or also the control stuff it comes with?
was removed in 1.15 btw, probably because of the rendering changes, and then forgotten
The controller stuff is still there, but it lacks the visual feedback. I could not figure out how to ride a horse until I played 1.12.
no it's not. the horse tracker is non functional atm, it's just the same as regular movement, point an walk https://github.com/Vivecraft/VivecraftMod/blob/3463cbbaca81d1d59baf6586979cd91413e2192b/common/src/main/java/org/vivecraft/client_vr/gameplay/trackers/HorseTracker.java#L30-L32
That was not my experience when ridding a horse with 1.20. I need to double check with the latest and compare to 1.12 and get back to you.
I did some testing and can confirm that controlling the horse still rotates as if it had reins. At least with my setup with index controllers. The thumb stick is configured to control movement, and the movement direction being controlled by where the left controller is pointing. To verify there was nothing strange about my setup I did this using a clean install in a new folder.
To test this, mount a horse in 1.20, hold your left arm forward than move your right arm, the horse will rotate. Now press forward, the horse will move the direction it is pointing, not the direction the left controller is pointing.
I also tested in 1.12.2-jrbudda-11-r2 and interestingly (at least with the default settings) the horse will just move in the direction you are pointing in-spite of the fact the reins are controlling the direction the horse is pointing.
trying it out, I think that is just the a side effect, of how the player model forward rotaion is done, and the fore points where the player model is pointing at
On closer inspection I think you are right as rotating my head without moving my hands changes the direction slightly.
I think the real bug is that the horse moves the direction it is pointing, not the direction your controller is pointing. I will open a new bug report for that.
Not for me. I just double checked, although it's not always in the direction the horse is pointing.
no it's not. the horse tracker is non functional atm, it's just the same as regular movement, point an walk
https://github.com/Vivecraft/VivecraftMod/blob/3463cbbaca81d1d59baf6586979cd91413e2192b/common/src/main/java/org/vivecraft/client_vr/gameplay/trackers/HorseTracker.java#L30-L32
also I double checked that on 1.12, the rein horse interaction isn't active there either, when active, it would allow to pull and snap the reins to get hte horse into a auto walk mode
sorry for the noise then, assuming #261 gets fixed, I consider this issue a very low priority