VivecraftMod icon indicating copy to clipboard operation
VivecraftMod copied to clipboard

Migrate the client configs

Open ferriarnus opened this issue 2 years ago • 8 comments

Moving the client settings to the same system as the server configs

ferriarnus avatar Sep 11 '23 20:09 ferriarnus

What about all the existing GUIs with localized tooltips? And what about everyone's existing options files? I dunno, this just kinda seems like a "if it ain't broke don't fix it" situation.

Techjar avatar Oct 20 '23 19:10 Techjar

I somewhat agree with you that working stuff should be left alone, however, having multiple systems for configs is a bit annoying. I've not looked into migrating the old ones, as I'm unsure if it's a big issue. For the guis, same as before: There's nothing really wrong with them, but multiple systems is hard to maintain.

ferriarnus avatar Oct 20 '23 20:10 ferriarnus

we can convert the old guis to use the new config system

fayer3 avatar Oct 20 '23 20:10 fayer3

I guess I'll just be sad to see my VRSettings framework go away. I spent a lot of time refactoring it into an easy-to-work-with state. (You guys should have seen the old system lmao)

Techjar avatar Nov 01 '23 11:11 Techjar

Yeah I get that, but I feel that toml is a bit of a nicer format (and is used by other mods so users will be familiar with it). I'm not a big fan of the massive enum, and annotations made it a bit more complex then needed imo. But the gui's can stay yeah. It's just that I wanted the server and client configs to have the same backend (and one which was hopefully less complex)

ferriarnus avatar Nov 01 '23 23:11 ferriarnus

yeah, we can keep the gui for now

fayer3 avatar Nov 01 '23 23:11 fayer3

Yeah I don't think mod menu is as organized or user-friendly for the amount of settings we have, so at least keeping the GUI is kind of necessary. We'll have to convert all the localization strings though.

Techjar avatar Nov 01 '23 23:11 Techjar

annotations made it a bit more complex then needed imo

The reason for annotations was to avoid having to use getIntValue() or whatever all over the place. It can be used as just a regular field with the actual type. I'm still not a fan of the Fabric config system for that reason.

Techjar avatar Nov 01 '23 23:11 Techjar