pulumi-kotlin icon indicating copy to clipboard operation
pulumi-kotlin copied to clipboard

Handle `liftSingleValueMethodReturns`

Open myhau opened this issue 2 years ago • 0 comments

Acceptance criteria

  • We understand what this property means (write on Slack or mention during the standup or add as the PR's description)
  • We have a test (CodegenTest) that checks whether Kotlin<->Java mapping works when this property is present (google-native or eks)

Notes

Impacted schemas: google-native and eks (might be more)

grep on all schemas (rg -i -C 10 liftSingleValueMethodReturns)

See output
rg -i -C 10 liftSingleValueMethodReturns
pulumi-schema-eks-v0.42.7.json
1515-                    }
1516-                },
1517-                "required": [
1518-                    "result"
1519-                ]
1520-            }
1521-        }
1522-    },
1523-    "language": {
1524-        "csharp": {
1525:            "liftSingleValueMethodReturns": true,
1526-            "packageReferences": {
1527-                "Pulumi": "3.*",
1528-                "Pulumi.Aws": "5.*",
1529-                "Pulumi.Kubernetes": "3.*"
1530-            }
1531-        },
1532-        "go": {
1533-            "generateResourceContainerTypes": true,
1534-            "importBasePath": "github.com/pulumi/pulumi-eks/sdk/go/eks",
1535:            "liftSingleValueMethodReturns": true
1536-        },
1537-        "java": {
1538-            "dependencies": {
1539-                "com.pulumi:aws": "5.4.0",
1540-                "com.pulumi:kubernetes": "3.19.1"
1541-            }
1542-        },
1543-        "python": {
1544:            "liftSingleValueMethodReturns": true,
1545-            "readme": "Pulumi Amazon Web Services (AWS) EKS Components.",
1546-            "requires": {
1547-                "pulumi": "\u003e=3.0.0,\u003c4.0.0",
1548-                "pulumi-aws": "\u003e=5.0.0,\u003c6.0.0",
1549-                "pulumi-kubernetes": "\u003e=3.0.0,\u003c4.0.0"
1550-            },
1551-            "usesIOClasses": true
1552-        }
1553-    }
1554-}

pulumi-schema-google-native-v0.27.0.json
7-        "google cloud",
8-        "category/cloud",
9-        "kind/native"
10-    ],
11-    "homepage": "https://pulumi.com",
12-    "license": "Apache-2.0",
13-    "repository": "https://github.com/pulumi/pulumi-google-native",
14-    "publisher": "Pulumi",
15-    "language": {
16-        "csharp": {
17:            "liftSingleValueMethodReturns": true,
18-            "namespaces": {
19-                "accessapproval": "AccessApproval",
20-                "accessapproval/v1": "AccessApproval.V1",
21-                "accesscontextmanager": "AccessContextManager",
22-                "accesscontextmanager/v1": "AccessContextManager.V1",
23-                "accesscontextmanager/v1beta": "AccessContextManager.V1Beta",
24-                "analyticshub": "AnalyticsHub",
25-                "analyticshub/v1": "AnalyticsHub.V1",
26-                "analyticshub/v1beta1": "AnalyticsHub.V1Beta1",
27-                "apigateway": "APIGateway",
--
441-                "workflows": "Workflows",
442-                "workflows/v1": "Workflows.V1",
443-                "workflows/v1beta": "Workflows.V1Beta"
444-            },
445-            "packageReferences": {
446-                "Pulumi": "3.*"
447-            }
448-        },
449-        "go": {
450-            "importBasePath": "github.com/pulumi/pulumi-google-native/sdk/go/google",
451:            "liftSingleValueMethodReturns": true,
452-            "packageImportAliases": {
453-                "github.com/pulumi/pulumi-google-native/sdk/go/google/accessapproval/v1": "accessapproval",
454-                "github.com/pulumi/pulumi-google-native/sdk/go/google/accesscontextmanager/v1": "accesscontextmanager",
455-                "github.com/pulumi/pulumi-google-native/sdk/go/google/accesscontextmanager/v1beta": "accesscontextmanager",
456-                "github.com/pulumi/pulumi-google-native/sdk/go/google/analyticshub/v1": "analyticshub",
457-                "github.com/pulumi/pulumi-google-native/sdk/go/google/analyticshub/v1beta1": "analyticshub",
458-                "github.com/pulumi/pulumi-google-native/sdk/go/google/apigateway/v1": "apigateway",
459-                "github.com/pulumi/pulumi-google-native/sdk/go/google/apigateway/v1beta": "apigateway",
460-                "github.com/pulumi/pulumi-google-native/sdk/go/google/apigee/v1": "apigee",
461-                "github.com/pulumi/pulumi-google-native/sdk/go/google/apigeeregistry/v1": "apigeeregistry",
--
722-                "github.com/pulumi/pulumi-google-native/sdk/go/google/websecurityscanner/v1": "websecurityscanner",
723-                "github.com/pulumi/pulumi-google-native/sdk/go/google/websecurityscanner/v1alpha": "websecurityscanner",
724-                "github.com/pulumi/pulumi-google-native/sdk/go/google/websecurityscanner/v1beta": "websecurityscanner",
725-                "github.com/pulumi/pulumi-google-native/sdk/go/google/workflowexecutions/v1": "workflowexecutions",
726-                "github.com/pulumi/pulumi-google-native/sdk/go/google/workflowexecutions/v1beta": "workflowexecutions",
727-                "github.com/pulumi/pulumi-google-native/sdk/go/google/workflows/v1": "workflows",
728-                "github.com/pulumi/pulumi-google-native/sdk/go/google/workflows/v1beta": "workflows"
729-            }
730-        },
731-        "java": {
732:            "liftSingleValueMethodReturns": true,
733-            "packages": {
734-                "accessapproval/v1": "accessapproval.v1",
735-                "accesscontextmanager/v1": "accesscontextmanager.v1",
736-                "accesscontextmanager/v1beta": "accesscontextmanager.v1beta",
737-                "analyticshub/v1": "analyticshub.v1",
738-                "analyticshub/v1beta1": "analyticshub.v1beta1",
739-                "apigateway/v1": "apigateway.v1",
740-                "apigateway/v1beta": "apigateway.v1beta",
741-                "apigee/v1": "apigee.v1",
742-                "apigeeregistry/v1": "apigeeregistry.v1",
--
1006-                "workflowexecutions/v1": "workflowexecutions.v1",
1007-                "workflowexecutions/v1beta": "workflowexecutions.v1beta",
1008-                "workflows/v1": "workflows.v1",
1009-                "workflows/v1beta": "workflows.v1beta"
1010-            }
1011-        },
1012-        "nodejs": {
1013-            "dependencies": {
1014-                "@pulumi/pulumi": "^3.0.0"
1015-            },
1016:            "liftSingleValueMethodReturns": true,
1017-            "readme": "The native Google Cloud Provider for Pulumi lets you provision Google Cloud resources in your cloud\nprograms. This provider uses the Google Cloud REST API directly and therefore provides full access to Google Cloud.\nThe provider is currently in public preview and is not recommended for production deployments yet. Breaking changes\nwill be introduced in minor version releases."
1018-        },
1019-        "python": {
1020:            "liftSingleValueMethodReturns": true,
1021-            "moduleNameOverrides": {
1022-                "accessapproval/v1": "accessapproval/v1",
1023-                "accesscontextmanager/v1": "accesscontextmanager/v1",
1024-                "accesscontextmanager/v1beta": "accesscontextmanager/v1beta",
1025-                "analyticshub/v1": "analyticshub/v1",
1026-                "analyticshub/v1beta1": "analyticshub/v1beta1",
1027-                "apigateway/v1": "apigateway/v1",
1028-                "apigateway/v1beta": "apigateway/v1beta",
1029-                "apigee/v1": "apigee/v1",
1030-                "apigeeregistry/v1": "apigeeregistry/v1",

Found when working on https://github.com/VirtuslabRnD/pulumi-kotlin/pull/106

liftSingleValueMethodReturns (in language.java) – not yet sure what this means. It was not present in the docs, but I found this in some schemas.

myhau avatar Nov 03 '22 21:11 myhau