scala-cli icon indicating copy to clipboard operation
scala-cli copied to clipboard

Build scalafmt native images for macOS ARM too

Open alexarchambault opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. VirtusLab/scalafmt-native-image only builds macOS native images of scalafmt for x86-64, not for aarch64.

Describe the solution you'd like Like VirtusLab/coursier-m1, it should have access to an M1 worker, so it should be able to build images for macOS ARM.

alexarchambault avatar Oct 21 '24 10:10 alexarchambault

Since https://github.com/scalameta/scalafmt/pull/4325 recently got merged, VirtusLab/scalafmt-native-image should no longer be necessary and the native images should be built with Scala Native in the scalameta repo instead. This applies to the MacOS arm native images as well, since we can now use the official GitHub runners for this.

Either way, I'm thinking this should be raised upstream rather than here.

Gedochao avatar Oct 21 '24 11:10 Gedochao

@Gedochao Did Scala CLI switch to launchers generated from scalameta/scalafmt already?

alexarchambault avatar Oct 21 '24 11:10 alexarchambault

Not yet. We should, however.

Gedochao avatar Oct 21 '24 18:10 Gedochao

Please, it's slow on my M3 book when running scala-cli fmt on pekko project, thanks

He-Pin avatar Dec 21 '24 17:12 He-Pin

https://github.com/VirtusLab/scalafmt-native-image has been sunset. Since scalafmt 3.9.1, native images are built in https://github.com/scalameta/scalafmt Feel free to re-raise this there. Closing the issue here.

Gedochao avatar Mar 05 '25 11:03 Gedochao