scala-cli icon indicating copy to clipboard operation
scala-cli copied to clipboard

Test the REPL with the Scala 3 REPL rather than Ammonite

Open Gedochao opened this issue 1 year ago • 0 comments

Is your feature request related to a problem? Please describe. We currently test a number of things in our REPL integration tests using Ammonite (see https://github.com/VirtusLab/scala-cli/pull/3209). As Scala CLI is closely tied with Scala 3 releases and Ammonite is maintained separately, we should uncouple these 2 things. The way things are, it's hard to guess what works until there's an Ammonite version for a given Scala version ready (which sometimes happens late or not at all, like with Scala 3.4.0/3.4.1)

Describe the solution you'd like We should test all repl sub-command features via the Scala 3 REPL rather than Ammonite REPL. The only tests relying on Ammonite should be the ones testing the actual integration.

We should run all REPL tests for Scala 3 using the Scala 3 REPL, rather than Ammonite (except for the tests where we do, in fact, test whether the Ammonite integration works as expected).

Dependencies

  • https://github.com/scala/scala3/issues/21242

Additional context

  • https://github.com/VirtusLab/scala-cli/pull/3209
  • https://github.com/com-lihaoyi/Ammonite/issues/1563
  • https://github.com/com-lihaoyi/Ammonite/issues/1395

Gedochao avatar Sep 26 '24 11:09 Gedochao