scala-cli
scala-cli copied to clipboard
VirtusLab
Scalafix command for scala-cli with basic optionns and tests
Hey, thanks for the contribution! I'll make sure to review this as soon as I am available, but given the volume of code included, I might need a couple days to get to it.
NOTE: After this is cleaned up and merged, we'll want to merge the scalafix sub-command with the fix sub-command (there's no point to keep them separate).
Individual fix features would probably be enabled/disabled by flags.
We'll do that as a follow-up, no need to worry about it in this PR.
Thanks @bjaglin!
@Vigorge if you are at any point overwhelmed by amount of comments, we are here to help. You already did a lot of great work :heart_eyes:
Thanks @bjaglin!
@Vigorge if you are at any point overwhelmed by amount of comments, we are here to help. You already did a lot of great work 😍
Thanks a lot for such an impactful feedback! These comments are really helpful and I'll surely take them into account. I really hope that I will resolve them in a few days and add some more features. Unfortunately, I had to take a little break, but now am fully committed to work more on this PR now
Not sure why didn't the CI run, but a rebase from main seems to be necessary, anyway.
Great to see activity on this — I think this could be big for Scalafix, in terms of people being able to use it more easily.
Hi, sorry for taking such a long time to resolve all those threads and thanks a lot again for such feedback.
The PR is ready for review.
Thanks for the follow-ups @Vigorge 👍 I will take a look at the PR tomorrow.
@Vigorge how's the progress on this? Can we unblock you somehow?
HI, still am working on the native image solution and gonna add feature in few days.
Thanks for support! I will comment here if some help will be needed.
@Gedochao Hi, we did changes in MR to make scalafix work both in jvm and native builds. Could you approve CI run?
Update. I need one additionial iteration to go trough comments from @bjaglin (add a bit more docs and tests) but in general I hope the PR is close to completion.
@dos65 @Vigorge Do you have time to address the remaining comments? Do you need help? I think it's also fine to extract any remaining work to separate issues at this stage.
Other than that, it seems docs-tests is still failing, there seems to still be some issues in website/docs/commands/scalafix.md. Let me know if you need help with that.
@Gedochao I started solving these comments. I hope will complete that in one-two evenings
@Gedochao There are some failed native-macos tests. I hope they are flaky. Otherwise I have no idea what might be wrong with them
Great work @dos65 ! @Gedochao is out seek, so we can wait for him to take a look next week.
Sorry for nitpicking, but the title seems to have a typo:
- Scalafix command for scala-cli with basic optionns and tests
+ Scalafix command for scala-cli with basic options and tests
Really looking forward to this PR!
I'll merge this once Scala CLI 1.5.3 is out.
...make that 1.5.4 😩 (https://github.com/VirtusLab/scala-cli/issues/3273#issuecomment-2476641331)