git-machete icon indicating copy to clipboard operation
git-machete copied to clipboard

git_operations.py should be as machete-agnostic as possible

Open PawelLipski opened this issue 2 years ago • 2 comments

In particular, I'm not happy about rebase calling machete-pre-rebase hook, which is a git-machete-specific thing. TBD what else should me moved away from git_operations.py (Ctrl+F for machete).

PawelLipski avatar Mar 26 '22 19:03 PawelLipski

@PawelLipski needs clarification.

machete is found:

What's wrong with them?

AABur avatar May 09 '22 20:05 AABur

Huh nothing wrong specifically with the above... it's a matter of general design soundness: having well-separated layers so that the lower layers (git_operations) don't know anything about the higher layers (client, which has Machete-specific stuff). I'd suggest moving methods up to MacheteClient and/or passing stuff (GIT_MACHETE_REBASE_OPTS?) as parameters to git_operations methods

PawelLipski avatar May 10 '22 11:05 PawelLipski