git-machete-intellij-plugin icon indicating copy to clipboard operation
git-machete-intellij-plugin copied to clipboard

Use javaLauncher in lexer and parser task

Open MaciejG604 opened this issue 3 years ago • 1 comments

This change should be merged when this PR makes it into master of the gradle-grammar-kit-plugin.

MaciejG604 avatar Oct 11 '22 08:10 MaciejG604

For a 100%-reliable repro:

FROM gitmachete/intellij-plugin-ci:9.0.0
RUN git clone https://github.com/MaciejG604/gradle-grammar-kit-plugin --branch=refactor-tasks-to-javaexec --depth=1 ggkp/
WORKDIR ggkp/
RUN sed -i 's/version=.*/version=2022.2.3-SNAPSHOT/' gradle.properties
RUN ./gradlew publishToMavenLocal
WORKDIR ..
RUN git clone https://github.com/VirtusLab/git-machete-intellij-plugin --branch=chore/java-version-for-lexer-parser-tasks --depth=1 gmip/
WORKDIR gmip/
RUN git fetch --tags
RUN sed -i 's/gradlePluginPortal()/mavenLocal(); &/' frontend/file/build.gradle.kts
RUN sed -i 's/gradle-grammarkit-plugin:[^"]*/gradle-grammarkit-plugin:2022.2.3-SNAPSHOT/' gradle/libs.versions.toml
RUN ./gradlew frontend:file:generateLexer
RUN ./gradlew frontend:file:generateParser

Now it passes 🎉 and it wouldn't without the fix to gradle-grammar-kit-plugin

PawelLipski avatar Oct 11 '22 13:10 PawelLipski

Too early :(

MaciejG604 avatar Oct 25 '22 08:10 MaciejG604

🤔

New version of https://github.com/JetBrains/gradle-grammar-kit-plugin is still pending

PawelLipski avatar Oct 25 '22 16:10 PawelLipski

Note the version change in the above repro:

RUN sed -i 's/gradle-grammarkit-plugin:[^"]*/gradle-grammarkit-plugin:2022.2.3-SNAPSHOT/' gradle/libs.versions.toml

PawelLipski avatar Oct 25 '22 16:10 PawelLipski

Given that https://github.com/JetBrains/gradle-changelog-plugin has just been released... I hope that gradle-grammat-kit-plugin is next-ish in the queue (as they're maintained by the same guy, @hsz) 😅

PawelLipski avatar Oct 29 '22 16:10 PawelLipski

Closing in favor of #1331

PawelLipski avatar Nov 20 '22 14:11 PawelLipski