besom icon indicating copy to clipboard operation
besom copied to clipboard

upgrade grpc dependency to >= 1.65.1 to avoid grpc corruption

Open adriaanm opened this issue 1 year ago • 5 comments

Just ran into https://github.com/grpc/grpc-java/issues/11284 today because I had some other dependency along with besom that bumped netty to 4.1.111.

The error I saw was:

ERROR besom.internal.ResourceDecoder.resolve:97
 Resolve resource: received error from gRPC call: 'INTERNAL: Encountered end-of-stream mid-frame', failing resolution
 2024.09.11 06:36:46:161 main  ERROR besom.internal.BesomModule.run:70
   io.grpc.StatusRuntimeException: INTERNAL: Encountered end-of-stream mid-frame

resolved for now by downgrading that dependency to get back to an older netty

adriaanm avatar Sep 11 '24 09:09 adriaanm

Hi @adriaanm, could you tell me how did you arrive in a situation where another dependency brought netty to the classpath of a besom program?

I'd gladly bump grpc deps but we do seem to have a little dependency problem in that area and I can recall that we could only bump them to versions that did not lead to scalapb explosion in runtime. I'll take another look tomorrow.

lbialy avatar Sep 25 '24 20:09 lbialy

Sure, it happened when I bumped this dependency: "software.amazon.awssdk" % "eks" % "2.25.70" (<-- this one works, but the 2.27.x series does not)

adriaanm avatar Oct 15 '24 10:10 adriaanm

@prolativ just hit this (the same route btw - AWS SDK) and we've went through whether we can bump deps for 0.4.0 and have this done but it turns out the latest stable scalapb - 0.11.17 has a dependency on io.grpc » grpc-protobuf | 1.62.2 and I recall that before 0.3.2 I tried to unbork that manually, bumped the grpc deps manually and then everything went red in integration tests.

seems we're blocked until scalapb 1.0.0 comes out, the alpha release is using 1.68.0 so it should allow for successful use of netty 4.1.111.Final underneath.

lbialy avatar Oct 21 '24 12:10 lbialy

It seems like the last version of AWS SDK not affected by this problem is 2.26.9 (tested with "software.amazon.awssdk" % "lambda")

prolativ avatar Oct 21 '24 14:10 prolativ

I'll be looking into versioning bumps in 0.5.1, just letting myself know.

lbialy avatar Oct 04 '25 16:10 lbialy